Closed Bug 1134471 Opened 9 years ago Closed 9 years ago

Enable Firefox What's New For FF 37

Categories

(Release Engineering :: Release Requests, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox37+ fixed)

RESOLVED FIXED
Tracking Status
firefox37 + fixed

People

(Reporter: bensternthal, Assigned: bhearsum)

References

Details

Attachments

(1 file)

In support of the Grow Android initiative that Winston is working on, we are creating a custom What's New Page for firefox 37 launching on 3/31.

This page should only be enable for 37 and turned off when 38 goes live approximately a month later.

Please let me know if you need any additional information.
For a standard whatsnew page, this can be controlled server-side.
Component: General → Releases
Product: Firefox → Release Engineering
QA Contact: rail
Version: 37 Branch → unspecified
This is already in place from the Loop whatsnew for 36.0. The only thing we might want to do is update the comment at http://hg.mozilla.org/build/buildbot-configs/file/default/mozilla/release-firefox-mozilla-release.py.template#l42
Blocks: 1119237
Capturing a note here from email conversation.

This should be turned on for all locales. We are doing the geo targeting on the web-side.
I updated the comment. bug 1138564 seems to have some disagreement about whether or not we want this for all locales or not. I'm going to assume that we do want it for all, but please let me know ASAP if that changes.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8576647 - Flags: checked-in+
Thanks Ben H for adding that comment. We have come to a consensus and we will no longer be adding what's new for everyone, instead we want to enable what's new for specific languages. These languages are as follows:

English (En-US)
English British (En-gb)
German (de)
Brazilian Portuguese (pt-BR)
Indonesian (id)
French (fr)
Spanish from Spain (es-ES)
Spanish from Mexico (es-MX)
(In reply to Ben (:bensternthal) from comment #5)
> Thanks Ben H for adding that comment. We have come to a consensus and we
> will no longer be adding what's new for everyone, instead we want to enable
> what's new for specific languages. These languages are as follows:
> 
> English (En-US)
> English British (En-gb)
> German (de)
> Brazilian Portuguese (pt-BR)
> Indonesian (id)
> French (fr)
> Spanish from Spain (es-ES)
> Spanish from Mexico (es-MX)

Okay, thanks for the advance notice on this! I'll prepare to do this for these locales. Just to be clear though, we don't have the ability to target users based on location. This means that, eg, someone who runs an en-US build in Japan will get the whatsnew page.
Since we'll be using a list of locales it would be great to finish bug 945179 first, to avoid an explosion of rules.
Depends on: 945179
Notes to future self:
* Automated Balrog submission will create release blob with whatsnew page enabled.
* Need to make a copy of that blob with the whatsnew page removed.
* Need to adjust rules to point the specified locales at the whatsnew page blob, and the rest at the modified blob.
* Should make that change on release-cdntest in advance of release to allow for testing
Chris - can you advise on who / how testing of this occurs. We are looking to do end to end testing tomorrow, I am familiar with testing the web bits but was hoping you could advise on the product side.
Flags: needinfo?(coop)
(In reply to Ben (:bensternthal) from comment #10)
> Chris - can you advise on who / how testing of this occurs. We are looking
> to do end to end testing tomorrow, I am familiar with testing the web bits
> but was hoping you could advise on the product side.

It's a comment in our build automation code. Automated test results for it are here:

https://travis-ci.org/mozilla/build-buildbot-configs/builds/54092996
Flags: needinfo?(coop)
(In reply to Chris Cooper [:coop] from comment #11)
> (In reply to Ben (:bensternthal) from comment #10)
> > Chris - can you advise on who / how testing of this occurs. We are looking
> > to do end to end testing tomorrow, I am familiar with testing the web bits
> > but was hoping you could advise on the product side.
> 
> It's a comment in our build automation code. Automated test results for it
> are here:
> 
> https://travis-ci.org/mozilla/build-buildbot-configs/builds/54092996

I think Ben is asking about testing the actual whatsnew pages. If that's the case, they can't be tested until we produce the 37.0 RC builds. Usually that's today, but it looks like we'll be waiting for a couple of fixes before doing that. Lawrence Mandel can probably give you a better ETA.
(In reply to Ben Hearsum [:bhearsum] from comment #8)
> Notes to future self:
> * Automated Balrog submission will create release blob with whatsnew page
> enabled.
> * Need to make a copy of that blob with the whatsnew page removed.

These are done.

> * Need to adjust rules to point the specified locales at the whatsnew page
> blob, and the rest at the modified blob.

This is waiting on getting the latest update server code pushed (bug 945179).

> * Should make that change on release-cdntest in advance of release to allow
> for testing

Slight change here: I'll be doing this on release-localtest, because release-cdntest won't be available until very close to release time. I'll update this bug again when the whatsnew page updates are ready for testing on release-localtest.
Lawrence based on comment #12 -- can you give me an ETA on when the RC builds will be available (and where I can grab them for testing).

As always... many thanks.
Flags: needinfo?(lmandel)
(In reply to Ben (:bensternthal) from comment #14)
> Lawrence based on comment #12 -- can you give me an ETA on when the RC
> builds will be available (and where I can grab them for testing).
> 
> As always... many thanks.

The builds are ready now, but the whatsnew pages aren't configured correctly yet. In order to test, you'll need to download an _older_ build of Firefox (eg, 36.0.4), change the channel to "release-localtest", launch the browser, and then check for an update.
Flags: needinfo?(lmandel)
With bug 945179 fixed, I set-up release-localtest and release-cdntest for this today. bensternthal did a quick verification with en-US, and I did some additional checks by hitting a few different URLs. We've got 37.0 RC2 coming soon, so we'll need to update the rules when it comes along, but that's no big deal.

We may want to disable it for release-localtest prior to RC2 going to build, otherwise update verify is going to fail at first...
I tested all the locales specified in this bug. They worked correctly.

However....

I tested icelandic firefox and I incorrectly got the what's new page.
Flags: needinfo?(bhearsum)
It looks like the release-localtest channel wasn't quite set up, so I fixed that and Icelandic looks fine now. (bhearsum: was pointing Firefox-37.0-build1 on rule 56, instead of Firefox-37.0-build1-no-whatsnew).
Flags: needinfo?(bhearsum)
Re-tested icelandic and hebrew, both correctly do not display what's new.

I am ok resolving this unless you will be doing additional testing.
Great, we can say the process is working. Should still double check the test channels when RC2 comes along, as well as when shipping for real.
Whoops, thanks to you both for catching/fixing the problem with non-whatsnew locales.

Now that build2 is ready I've updated the test channels to point at it. Ben, can you give them a quick try? One locale each that should/shouldn't have whatsnew should be fine.
Flags: needinfo?(bsternthal)
Re-tested..

pt-BR - whats new: correct \o/
ja - no whats new: correct \o/
Flags: needinfo?(bsternthal)
The 2 I tested worked correctly.
(In reply to Ben (:bensternthal) from comment #23)
> The 2 I tested worked correctly.

Excellent! We're ready to ship as far as whatsnew is concerned \o/.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
FYI, we're going to release Firefox 37.0.1 today. This release will receive the same what's new treatment as 37.0 with the exception that instances that were already updated to 37.0 will not see a what's new page when updating to 37.0.1. I'm told that we need to recreate the what's new configuration for this release so it is probably worth testing again once it's ready. hwine is working on the configuration now.
Flags: needinfo?(bsternthal)
Happy to help test. Just let me know when and where.
Flags: needinfo?(bsternthal)
kairo - Do you have details about how to test the what's new configuration with cdntest?
Flags: needinfo?(kairo)
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #27)
> kairo - Do you have details about how to test the what's new configuration
> with cdntest?

You need to change the update channel in defaults/pref/channel-prefs.js in the source build - otherwise, it's really manual testing, from all I know.
Flags: needinfo?(kairo)
I have done this in the past and it is not a problem.

Please let me know the exact value for the update channel and I shall test.
(In reply to Ben (:bensternthal) from comment #29)
> Please let me know the exact value for the update channel and I shall test.

"release-cdntest", see the supported values in https://wiki.mozilla.org/Releases/Update_Channels
Spot checked 3 FFs - everything worked as expected.

es (mexico) - whats new: correct \o/
pt-BR - whats new: correct \o/
is - no whats new: correct \o/
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: