Closed Bug 1134492 Opened 9 years ago Closed 9 years ago

[DAM] Code assets.mozilla.com links on moz.org properties

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: lizzn, Assigned: lismanb, Mentored)

References

Details

Attachments

(3 files)

Link to Github pull-request: https://github.com/mozilla/bedrock/pull/2772
44 bytes, text/x-github-pull-request
Details | Review
assets.m.o link changes in CSV format
27.41 KB, text/csv
Details
Asset Links Mozilla.csv - Asset Links Mozilla.csv.csv
27.06 KB, text/csv
Details 
Deadline: 03/06/2015 (go-live date)

We need to redirect about 170 links that on mozilla.org from the current assets.mozilla.com to the new URL (back-end is the NetX DAM).

I will post a list of the old and new links matched no later than next Wednesday, 02/25. 

Here's the updated deployment schedule: https://docs.google.com/a/mozilla.com/drawings/d/17z5XmgPuuHOtu4hSLW3jtenwzvPacmr1KxjDhE9uhgg/edit
Summary: [DAM] Redirect assets.mozilla.com links on moz.org properties → [DAM] Code assets.mozilla.com links on moz.org properties
Here's the list of links - the new ones are in column B: https://drive.google.com/a/mozilla.com/file/d/0BzHULT8I_KE6cFFka2tVOHFfWjhnbjYzMGlOVmpZTnRYSjlF/view?usp=sharing

Read to code! Please LMK if there are any questions. 

Thanks!
Lizz
Thanks, Lizz.  What are we doing with the "no asset" lines?

Steven - Do you have time to code these starting March 2 to be live March 6?  

Mike - We'll need to coordinate the push to prod with the DAM going live to production.
Flags: needinfo?(steven)
Flags: needinfo?(malexis)
Flags: needinfo?(acostello)
Sorry,  I should've flagged that right away. Those are the new developer edition logos and there were not links to in assets. I'm going to have Sean upload those today and then I'll update the list. Just wanted to post in in case there was time on your team this week to work on it.
Blocks: 1135936
So... a few things:

1. jakem discovered that assets.mozillalabs.com points at the same assets server. So we could change the links in bedrock now to assets.mozillalabs.com, then switch assets.mozilla.org to the new thing, then once that's done switch the links on the site to the new ones. This should mean no coordination is required and no downtime is experienced.

2. A new contributor (:blisman) is interested in helping us with this one, so we should be able to knock this out very soon. Since we can do it in 2 parts (2 separate PRs) they can both be started on now and we can merge them as the servers are ready.
Flags: needinfo?(steven)
Assignee: nobody → lismanb
Status: NEW → ASSIGNED
Mentor: pmac
(In reply to Paul McLanahan [:pmac] from comment #4)
> So... a few things:
> 
> 1. jakem discovered that assets.mozillalabs.com points at the same assets
> server. So we could change the links in bedrock now to
> assets.mozillalabs.com, then switch assets.mozilla.org to the new thing,
> then once that's done switch the links on the site to the new ones. This
> should mean no coordination is required and no downtime is experienced.
> 
> 2. A new contributor (:blisman) is interested in helping us with this one,
> so we should be able to knock this out very soon. Since we can do it in 2
> parts (2 separate PRs) they can both be started on now and we can merge them
> as the servers are ready.

Awesome! Thanks :blisman!

Here's the updated list with the missing links replaced: https://drive.google.com/file/d/0B7_WeTET1EQwcEpMSEJDZllvWVE/view?usp=sharing
(In reply to Lizz Noonan from comment #5)
> (In reply to Paul McLanahan [:pmac] from comment #4)
> > So... a few things:
> > 
> > 1. jakem discovered that assets.mozillalabs.com points at the same assets
> > server. So we could change the links in bedrock now to
> > assets.mozillalabs.com, then switch assets.mozilla.org to the new thing,
> > then once that's done switch the links on the site to the new ones. This
> > should mean no coordination is required and no downtime is experienced.
> > 
> > 2. A new contributor (:blisman) is interested in helping us with this one,
> > so we should be able to knock this out very soon. Since we can do it in 2
> > parts (2 separate PRs) they can both be started on now and we can merge them
> > as the servers are ready.
> 
> Awesome! Thanks :blisman!
> 
> Here's the updated list with the missing links replaced:
> https://drive.google.com/file/d/0B7_WeTET1EQwcEpMSEJDZllvWVE/view?usp=sharing

Sounds great!  I like this plan.  Thanks pmac and blisman!
PR for step 1: change links from assets.mozilla.org to assets.mozillalabs.com. We'll be changing the links per the spreadsheet next.
Adding the doc as a CSV for easier access by people who may not have access to the Google Doc.
Hi,
I've found some inconsistencies in the new urls. For instance:
 /assets/#asset/99
 /assets/#/asset/205 -> the extra slash after #

Is it a typo? or it's supposed to be like that?
Flags: needinfo?(enoonan)
(In reply to Bogdan L. from comment #9)
> Hi,
> I've found some inconsistencies in the new urls. For instance:
>  /assets/#asset/99
>  /assets/#/asset/205 -> the extra slash after #
> 
> Is it a typo? or it's supposed to be like that?

Not sure, I didn't pull the URLs. Let me ask NetX and I'll let you know.
Flags: needinfo?(enoonan)
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/89ad7c1f5549f2d9fb0a0da88d14a4995508b96b
Bug 1134492 - move assets from assets.mozilla.org to assets.mozillalabs.com

Updated the links in the html templates  that pointed towards
 assets.mozilla.org to point to assets.mozillalabs.org as a first step
 in resolving this issue

https://github.com/mozilla/bedrock/commit/4e01eb1a0876934301058262e166a94d5b02a9f9
Merge pull request #2772 from lismanb/bug1134492

Bug 1134492 - move assets.mozilla.org to assets.mozillalabs.com
all the urls are updated to use the new format from the csv file
This is the pull request for the second step.

https://github.com/mozilla/bedrock/pull/2784
I also just want to double check that we're doing the right thing. The final URLs will be like those from the latest spreadsheet, but will use the assets.mozilla.org domain right? The sheet uses mozilla.netx.net and mozillastaging.netx.net, but those aren't final if I'm understanding correctly. 

In Bogdan's PR from comment #12 he uses the assets.mozilla.org domain and our plan is to only merge and push these changes after the new system is live at this domain. Please let me know if I've misunderstood something. Otherwise I think we're ready for the switch.
(In reply to Paul McLanahan [:pmac] from comment #13)
> I also just want to double check that we're doing the right thing. The final
> URLs will be like those from the latest spreadsheet, but will use the
> assets.mozilla.org domain right? The sheet uses mozilla.netx.net and
> mozillastaging.netx.net, but those aren't final if I'm understanding
> correctly. 
> 
> In Bogdan's PR from comment #12 he uses the assets.mozilla.org domain and
> our plan is to only merge and push these changes after the new system is
> live at this domain. Please let me know if I've misunderstood something.
> Otherwise I think we're ready for the switch.

Sorry! I got to the bottom of it - she sent over the wrong sheet. These are the final links: https://docs.google.com/spreadsheets/d/1Ae1qKuG8Gn6iVzach-Szb_kVnWzdaQxKb6P0oLhgks4/edit?usp=sharing
Here are the correct final links in .csv 

Thanks!
Lizz
Lizz, Thanks! But, just so we're clear, the first two lines of the new file still have netx.net urls in them (e.g. https://mozilla.netx.net/portal/assets/#category/83), while the rest are what I expected (assets.mozilla.org). Those first two should also be assets.m.o right?
(In reply to Paul McLanahan [:pmac] from comment #16)
> Lizz, Thanks! But, just so we're clear, the first two lines of the new file
> still have netx.net urls in them (e.g.
> https://mozilla.netx.net/portal/assets/#category/83), while the rest are
> what I expected (assets.mozilla.org). Those first two should also be
> assets.m.o right?

Yes, they should be. Must've been another typo. Thanks!
Hey there - we're pushing the DAM live today. Just want to double check that the links have been coded and we're good to go! 

Thanks! 
Lizz
Flags: needinfo?(pmac)
I believe so. All of the links on the site are pointing to assets.mozillalabs.com right now. :blisman also has the pull-request to switich to the new links ready. As soon as we have confirmation that the new assets.mozilla.org is live and ready w/ the new system and URLs we'll merge the pull-request and push the changes live.
Flags: needinfo?(pmac)
(In reply to Paul McLanahan [:pmac] from comment #19)
> I believe so. All of the links on the site are pointing to
> assets.mozillalabs.com right now. :blisman also has the pull-request to
> switich to the new links ready. As soon as we have confirmation that the new
> assets.mozilla.org is live and ready w/ the new system and URLs we'll merge
> the pull-request and push the changes live.

The portal is now live: https://assets.mozilla.org/portal/assets/
(In reply to Lizz Noonan from comment #20)
> The portal is now live: https://assets.mozilla.org/portal/assets/

That site is giving me a bad certificate. It's still the SSL cert for netx.net. We need that fixed before we can change our links.
Flags: needinfo?(enoonan)
(In reply to Paul McLanahan [:pmac] from comment #21)
> (In reply to Lizz Noonan from comment #20)
> > The portal is now live: https://assets.mozilla.org/portal/assets/
> 
> That site is giving me a bad certificate. It's still the SSL cert for
> netx.net. We need that fixed before we can change our links.

Hmm, didn't happen for me. Jake, is that in progress now or is it something we need to fix?
Flags: needinfo?(enoonan) → needinfo?(nmaul)
It might just still be propagating.
"assets.mozilla.org uses an invalid security certificate. The certificate is only valid for the following names: *.netx.net, netx.net "
I get the same error.
Sorry - Netx is getting the SSL certificates from Jake. I thought they already had them. I'll send an update once the CSR key is created on their side.
Great! Thanks Lizz.
(In reply to Bogdan L. from comment #24)
> "assets.mozilla.org uses an invalid security certificate. The certificate is
> only valid for the following names: *.netx.net, netx.net "
> I get the same error.

I continue to see the above error for https://assets.mozilla.org/ (not http://) in Firefox/Safari/Chrome, so they aren't publishing the new certificate yet.
(In reply to Richard Soderberg [:atoll] from comment #27)
> (In reply to Bogdan L. from comment #24)
> > "assets.mozilla.org uses an invalid security certificate. The certificate is
> > only valid for the following names: *.netx.net, netx.net "
> > I get the same error.
> 
> I continue to see the above error for https://assets.mozilla.org/ (not
> http://) in Firefox/Safari/Chrome, so they aren't publishing the new
> certificate yet.

I've pinged netx to find out what's going on. More soon!
Flags: needinfo?(nmaul)
Flags: needinfo?(malexis)
Flags: needinfo?(acostello)
Beverly @ NetX sent me a CSR, and I just sent her back a certificate with the corresponding intermediate cert. Up to them now to get it set up. :)
NOTE: Just watched the DAM air.m.o presentation and checked the other domains (events.m.o and partners.m.o) and they both exhibit the same certificate issue as assets.m.o. Just FYI.
The certificates are in place! Check it out and if we can all replicate, let's close this boooooog.
No errors with safari or chrome mobile browsers on my iPhone - not by my laptop ATM.
All three sites are good for me as well, now. Thanks for helping us get these deployed!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Yup. Good from here. Thanks all! I'll merge the bedrock pull-request and get the styleguide updated in our next push.
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/78745584c6e185523d89a30538f2897bd32a51bc
Fix bug 1134492 - update templates to new urls on assets.mozilla.org

Updated the links in the html templates  that pointed towards
 assets.mozillalabs.org to point to assets.mozilla.org but to new urls
  as the final part of fixing this issue.

https://github.com/mozilla/bedrock/commit/f58ec74deb8d36d9b16ce5925f9550e210d1f331
Merge pull request #2784 from lismanb/bug1134492_done

Fix bug 1134492 - update templates to new urls on assets.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: