1134504 - [System] Scrolling long highlighted url in Rocketbar shows gaps and cut off letters

Status: RESOLVED DUPLICATE of bug 990907

(Core :: Panning and Zooming, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
When user taps rocketbar while on a website with a long url, scrolling left or right to reveal more of the url shows strange gaps and cut off characters making URL impossible to read.

Repro Steps:
1) Update a Flame to 20150218010226
2) Navigate to any website (e.g. google search results)
3) Tap rocketbar
4) Slowly scroll in rocketbar to reveal more of the url

Actual:
Gaps and cut off characters appear on highlighted url during and after scrolling.

Expected:
Highlighted URL is readable with no gaps or cut off characters.

Environmental Variables:
Device: Flame 3.0 Master
Build ID: 20150218010226
Gaia: 82f286f10a41aab84a0796c89fbefe67b179994b
Gecko: 9696d1c4b3ba
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 3/3, 100%
See attached: Screenshot

Comment 1

[Brogan Zumwalt [Inactive]]

Leaving QAWanted for branch checks and video of issue.

Comment 2

[Brogan Zumwalt [Inactive]]

Issue DOES reproduce on Flame 2.2

Gaps and cut off characters appear on highlighted url during and after scrolling.

Device: Flame 2.2
Build ID: 20150219002504
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: 159a3907b959
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Issue does NOT reproduce on Flame 2.1

Highlighted URL is readable with no gaps or cut off characters.

Device: Flame 2.1
Build ID: 20150219001626
Gaia: a43e3cdf8783e9d87156d47b8bfff0f5f44f9e2e
Gecko: 5653f229724f
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 3

[Brogan Zumwalt [Inactive]]

Video of issue: http://youtu.be/rJKppclSG5E

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does occur on the Flame 2.1

Although it does not remain, I can see gaps and cut off characters appear within the highlighted url during scrolling.

Environmental Variables:
Device: Flame 2.1
BuildID: 20150219001626
Gaia: a43e3cdf8783e9d87156d47b8bfff0f5f44f9e2e
Gecko: 5653f229724f
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------

I could not get this issue to occur on Flame 2.0 

No gaps or cut off characters appeared when scrolling the highlighted url.

Environmental Variables:
Device: Flame 2.0
BuildID: 20150219000202
Gaia: ecb1bbc3b9c00f82df172427f65d6f67e34ed533
Gecko: c76040f40105
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

This looks bad so nominating for 2.2? since the missing letters and gaps remain after the user has stopped scrolling on 2.2 and 3.0. In 2.1 this only can be seen while scrolling the URL, it does not remain.

Comment 6

[Gregor Wagner [:gwagner]]

Milan, this seems to be gfx related.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Wouldn't surprise me if it's a dupe of one of the bugs Benoit and/or Kats are tracking.

Comment 8

[Benoit Girard (:BenWa)]

It doesn't look like it. I remember seeing a bug where CSS overflow:ellipsis would cause bad invalidation but I can't find the bug.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

I can repro this, and it generally only happens when scrolling the URL towards the right. I agree with BenWa it's related to the ellipsis, and isn't related to any of the other graphical glitches we're tracking under bug 1134202. I suspect if we finally fix bug 990907 this will go away. It was probably exacerbated in 2.2+ because now we're scrolling that input field with APZ instead of synchronously.

Comment 10

[Yeojin Chung [:YeojinC]]

Mozilla-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150201170935
Gaia: 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko: 231a8c61b49f
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150201174135
Gaia: 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko: bcefc7d8d885
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce 
Gaia: 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko: bcefc7d8d885

First Broken Gaia Last Working Gecko: Issue does NOT reproduce
Gaia: 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko: 231a8c61b49f

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=231a8c61b49f&tochange=bcefc7d8d885

caused by bug 950934

Comment 11

[Yeojin Chung [:YeojinC]]

I found the regression window based on the behavior that the URL remains selected while scrolling.

Comment 12

[KTucker [:KTucker][Inactive 3/4/2016]]

Botond, can you take a look at this please? Looks like the work done on Bug 950934 might be the culprit here.

Comment 13

[Botond Ballo [:botond]]

Confirmed that removing "text-overflow: ellipsis" from the rocketbar's input field makes the problem go away, although the input field is still clipped too much, creating a "checkerboarding" effect as you async-scroll it (this is probably an unrelated bug).

I will continue to investigate.

Comment 14

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #13)
> although the input field is still clipped
> too much, creating a "checkerboarding" effect as you async-scroll it (this
> is probably an unrelated bug).

Ah, this is probably bug 990974.

Comment 15

[Botond Ballo [:botond]]

The same glitching happens in the test case attached to bug 990974, so there is no issue specific to the the rocketbar's text input, nor is there likely to be a fix specific for it. We should just fix bug 990974.

Comment 16

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #15)
> The same glitching happens in the test case attached to bug 990974, so there
> is no issue specific to the the rocketbar's text input, nor is there likely
> to be a fix specific for it. We should just fix bug 990974.

Er, I meant bug 990907 in both cases.

Comment 19

[Kartikaya Gupta (email:[e-mail])]

This should be fixed now on master now that bug 990907 is fixed - I can't reproduce it locally, but flagging qawanted to verify more thoroughly.

I've requested uplift on bug 990907 to 2.2 to fix it there, but I think the root cause on 2.1 is probably different because we don't have parent-process-APZ there.

Comment 20

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: The breakage in selected URL does not occur anymore.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150226010233
Gaia: 7894b929f1b0394f3c997f72a6482bc7813e758d
Gecko: dd6353d61993
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
===========================================
leaving verifyme for 2.2 uplift/verification.