[EME] Create a teaching moment on first play of DRM-protected content

RESOLVED FIXED in Firefox 38

Status

()

Firefox
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: javaun, Assigned: Gijs)

Tracking

38 Branch
Firefox 39
x86
All
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify -

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
On first play of DRM-protected content, we want to notify user that something is different by calling attention to the new icon in the URL bar.
(Reporter)

Comment 1

2 years ago
Dolske needs a UX spec and final artwork to handle the teaching moment on first play.
Assignee: nobody → sfranks
Blocks: 1083662
OS: Mac OS X → All
Version: unspecified → Firefox 38
Icon shake animation: http://people.mozilla.org/~sfranks/EME/shake.gif

Plays only once open detection of DRM content. Not sure if it should wait until the actual playing of content as if motion appears on the screen instantly after pressing play, it may take all the attention away from the icon shake.

Can we tell from the source code if the content on a page will use the CDM before the user presses play?
Flags: needinfo?(philipp)
Flags: needinfo?(dolske)
We do not currently watch for first-play, just whenever EME is used by content. That feels like a complication that isn't important -- when we add the icon (because EME usage had been triggered), we can shake the icon then.
Flags: needinfo?(dolske)
(Reporter)

Comment 4

2 years ago
So, is the idea here to display the "shaker" animation on first display of the url bar icon (triggered by first usage of EME)?
(Assignee)

Updated

2 years ago
Assignee: sfranks → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 39.1 - 9 Mar
Points: --- → 3
Flags: needinfo?(philipp)
(In reply to Javaun Moradi [:javaun] from comment #4)
> So, is the idea here to display the "shaker" animation on first display of
> the url bar icon (triggered by first usage of EME)?

Yes, precisely.
(Assignee)

Comment 6

2 years ago
Created attachment 8568577 [details] [diff] [review]
shaky eme icon on first play,

This wfm, keep in mind you need to restart the browser (and clear the pref) for the animation to play a second time (or mess with the CSS / DOM in some other way).
Attachment #8568577 - Flags: review?(sfranks)
(Assignee)

Updated

2 years ago
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
(Reporter)

Comment 7

2 years ago
Thanks Gijs. Can you post which pref to clear here so we can test later?
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 8

2 years ago
browser.eme.ui.firstContentShown

is the pref in question.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Gijs Kruitbosch from comment #6)
> Created attachment 8568577 [details] [diff] [review]
> shaky eme icon on first play,
> 
> This wfm, keep in mind you need to restart the browser (and clear the pref)
> for the animation to play a second time (or mess with the CSS / DOM in some
> other way).

Would you be able to push a build or record a video of how it looks? Sorry, I have never made a build before (but would like to learn when I have more bandwidth).
(Assignee)

Updated

2 years ago
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 10

2 years ago
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea24779be4b5

Builds will appear at:

https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/gijskruitbosch@gmail.com-ea24779be4b5
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8568577 [details] [diff] [review]
shaky eme icon on first play,

Looks great.
Attachment #8568577 - Flags: review?(sfranks) → review+
(Assignee)

Comment 12

2 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/279bf3bf6c43
https://hg.mozilla.org/mozilla-central/rev/279bf3bf6c43
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
(Assignee)

Comment 14

2 years ago
Comment on attachment 8568577 [details] [diff] [review]
shaky eme icon on first play,

Approval Request Comment
[Feature/regressing bug #]: EME UI
[User impact if declined]: user might miss EME UI
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, mostly CSS changes for the animation and a small bit of JS to trigger it.
[String/UUID change made/needed]: no

(NB: please transplant for uplift, the attached patch only has OS X css)
Attachment #8568577 - Flags: approval-mozilla-aurora?
Comment on attachment 8568577 [details] [diff] [review]
shaky eme icon on first play,

Approving for uplift to aurora since this looks low risk. 
 
Lukas mentioned that the note about "transplanting" is for the sheriffs. Gijs, what does that mean? Thanks!
Attachment #8568577 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is there an accessibility affordance for this shaky animation in the tab, or a plan for one in the future? How might screen readers get feedback about this?
Flags: needinfo?(dbolter)
(Assignee)

Comment 17

2 years ago
(In reply to jstrickland from comment #16)
> Is there an accessibility affordance for this shaky animation in the tab, or
> a plan for one in the future? How might screen readers get feedback about
> this?

AIUI the notifications have role alert and therefore get announced - unless that doesn't work if they start off collapsed? David, can you file a followup bug in that case?
https://hg.mozilla.org/releases/mozilla-aurora/rev/0d1531a43a58
status-firefox38: --- → fixed
Thanks for asking! Bumping NI over to Marco to test next week.
Flags: needinfo?(dbolter) → needinfo?(mzehe)
Depends on: 1145035
OK, in order to be able to test this, I need access to something that actually has EME content. I am not a Netflix user, so have no private account to test this with. I also don't know where else I might find EME content, never came across it AFAIK.
(Assignee)

Comment 21

2 years ago
Marco: http://people.mozilla.org/~cpearce/mse-clearkey/ should work on current Nightly/Aurora.
This page doesn't give me any indication that this is anything other than an ordinary video that you can also find on Youtube. Video playback controls are there, the video plays, but I don't get any indication that there is anything special about it. No notification bar or other alert type whatsoever.
Flags: needinfo?(mzehe)
Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl
Version: Firefox 38 → 38 Branch
You need to log in before you can comment on or make changes to this bug.