Closed
Bug 1134536
Opened 9 years ago
Closed 9 years ago
Rename languages-provided.ab-CD.version to "revision"
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect)
Firefox OS Graveyard
Gaia::L10n
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S6 (20feb)
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
stas
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
This is the Gaia part of bug 1133725.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8566427 [details] [review] [gaia] stasm:1134536-langpack-revision > mozilla-b2g:master Carrying over Zibi's review from bug 1133725 comment 14.
Attachment #8566427 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f88d304eee04c6e515c942b19464388e6488edec
|
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•9 years ago
|
||
L20n.js: https://github.com/l20n/l20n.js/commit/a468f41d922745770957530ebdeca955df5d6bcd
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8566427 [details] [review] [gaia] stasm:1134536-langpack-revision > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 1133725 in which we're changing "version" to "revision" in the spec [User impact] if declined: langpacks won't work [Testing completed]: on the device [Risk to taking this patch] (and alternatives if risky): low; it's a simple search & replace change [String changes made]: none
Attachment #8566427 -
Flags: approval-gaia-v2.2?
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8566427 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2?(bbajaj)
|
||
Updated•9 years ago
|
Attachment #8566427 -
Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/91daca32fda467a61ed78ad216cc0685c2b85cbb
Assignee: nobody → stas
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Target Milestone: --- → 2.2 S6 (20feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•