Closed Bug 1134540 Opened 5 years ago Closed 2 years ago

All tests using nsIDOMWindowUtils.sendKeyEvent() should use nsITextInputProcessor

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

nsIDOMWindowUtils.sendKeyEvent() is now deprecated. All tests using it should use nsITextInputProcessor, instead.
Hmm, looks like that we need to fix for bug 968056 because TextInputProcessor decides if keypress event should be fired for each keyboard event but tests using nsIDOMWindowUtils.sendKeyEvent() don't do it.
Status: NEW → ASSIGNED
Comment on attachment 8947008 [details]
Bug 1134540 - Make all tests stop using nsIDOMWindowUtils.sendKeyEvent()

https://reviewboard.mozilla.org/r/216826/#review222656

rs+

Should we remove nsIDOMWindowUtils.sendKeyEvent()?
Attachment #8947008 - Flags: review?(bugs) → review+
Comment on attachment 8947008 [details]
Bug 1134540 - Make all tests stop using nsIDOMWindowUtils.sendKeyEvent()

https://reviewboard.mozilla.org/r/216826/#review222656

Yes, I have a patch. However, I'll wait fixes of comm-central for a couple of weeks. So, I'd like to remove it in the cycle of 60.
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/e5450e8bff04
Make all tests stop using nsIDOMWindowUtils.sendKeyEvent() r=smaug
https://hg.mozilla.org/mozilla-central/rev/e5450e8bff04
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.