[Shinano][Aries] Missing cpufreq governor configuration

RESOLVED INVALID

Status

RESOLVED INVALID
4 years ago
2 years ago

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
We are lacking /system/etc/set_governor.sh
(Assignee)

Comment 1

4 years ago
Created attachment 8566459 [details] [review]
Shinano common PR
Attachment #8566459 - Flags: review?(mwu)

Comment 2

4 years ago
Comment on attachment 8566459 [details] [review]
Shinano common PR

I don't see how it's possible for this script to run. It's triggered on the bootanimation service ending, but we don't have a bootanimation service at all.
(Assignee)

Comment 3

4 years ago
Worst, you are right, I checked the rc file where I saw it, and there is a 'disabled' keyword. So, indeed, we probably don't need it.
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
(Assignee)

Updated

4 years ago
Attachment #8566459 - Flags: review?(mwu)

Comment 4

4 years ago
Well, it might be a good thing to run, but just copying that file won't make it work.
Created attachment 8678579 [details] [review]
Shinano KK PR
Flags: needinfo?(lissyx+mozillians)
Attachment #8678579 - Flags: review?(mwu)
Created attachment 8678580 [details] [review]
Shinano L PR

Luckily only shinano needs this, yukon already uses sys.boot_completed=1
Attachment #8678580 - Flags: review?(mwu)

Updated

3 years ago
Attachment #8678579 - Flags: review?(mwu) → review?(lissyx+mozillians)

Updated

3 years ago
Attachment #8678580 - Flags: review?(mwu) → review?(lissyx+mozillians)
(Assignee)

Comment 7

3 years ago
I have been checking and on my device, the governor is the proper one. Most of the values being set by set_governor.sh are already there, so I'm not sure if there anything we should really fix.
Flags: needinfo?(lissyx+mozillians)
(Assignee)

Comment 8

3 years ago
I'll give this another check, this has been pending for too long :)
(Assignee)

Updated

2 years ago
Attachment #8678579 - Flags: review?(lissyx+mozillians)
(Assignee)

Updated

2 years ago
Attachment #8678580 - Flags: review?(lissyx+mozillians)
You need to log in before you can comment on or make changes to this bug.