Closed Bug 1134573 Opened 9 years ago Closed 9 years ago

[Shinano][Aries] Missing cpufreq governor configuration

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

Product:
Firefox OS Graveyard
Component:
GonkIntegration
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Details

Attachments

(3 files)

Shinano common PR
59 bytes, text/x-github-pull-request
Details | Review
Shinano KK PR
60 bytes, text/x-github-pull-request
Details | Review
Shinano L PR
58 bytes, text/x-github-pull-request
Details | Review 
We are lacking /system/etc/set_governor.sh
Attached file Shinano common PR — 

        Attachment #8566459 -
        Flags: review?(mwu)

    
    

    
  
Comment on attachment 8566459 [details] [review]
Shinano common PR

I don't see how it's possible for this script to run. It's triggered on the bootanimation service ending, but we don't have a bootanimation service at all.

    
    

    
  
Worst, you are right, I checked the rc file where I saw it, and there is a 'disabled' keyword. So, indeed, we probably don't need it.

    
  
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID

    
  

        Attachment #8566459 -
        Flags: review?(mwu)

    
    

    
  
Well, it might be a good thing to run, but just copying that file won't make it work.

    
    

    
  

      
      
      
      

        Attached file
          
        Shinano KK PR
        — 
      

    


  
Flags: needinfo?(lissyx+mozillians)

        Attachment #8678579 -
        Flags: review?(mwu)

    
    

    
  

      
      
      
      

        Attached file
          
        Shinano L PR
        — 
      

    


  
Luckily only shinano needs this, yukon already uses sys.boot_completed=1

        Attachment #8678580 -
        Flags: review?(mwu)

    
  

        Attachment #8678579 -
        Flags: review?(mwu) → review?(lissyx+mozillians)

    
  

        Attachment #8678580 -
        Flags: review?(mwu) → review?(lissyx+mozillians)

    
    

    
  
I have been checking and on my device, the governor is the proper one. Most of the values being set by set_governor.sh are already there, so I'm not sure if there anything we should really fix.
Flags: needinfo?(lissyx+mozillians)

    
    

    
  
I'll give this another check, this has been pending for too long :)

    
  

        Attachment #8678579 -
        Flags: review?(lissyx+mozillians)

    
  

        Attachment #8678580 -
        Flags: review?(lissyx+mozillians)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: