Closed Bug 1134600 Opened 9 years ago Closed 9 years ago

worker.terminate() keeps the worker in memory is a BroadcastChannel is opened.

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: vingtetun, Assigned: baku)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

229877.diff
1.95 KB, patch
Details | Diff | Splinter Review 
If a page opens a worker, and share a BroadcastChannel, calling worker.terminate() stop the worker but keeps it in memory.

Open the related url.
Search for worker.js in about:memory
Isn't this Olli's cross thread cycle collection thing?
Flags: needinfo?(bugs)
Well, as of now, this is about the manual memory management of workers and broadcastchannel.
Flags: needinfo?(bugs) → needinfo?(amarchesini)
Attached patch bc.patch (obsolete) — — Splinter Review 
Flags: needinfo?(amarchesini)

        Attachment #8566698 -
        Flags: review?(bugs)

        Attachment #8566698 -
        Flags: review?(bugs) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c649b0112e6d
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox38:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: