Closed Bug 1134626 Opened 6 years ago Closed 5 years ago

Clean-up: Share Architecture code of x86 & x64.

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: nbp, Assigned: nbp)

References

Details

Attachments

(2 files)

Bug 1112164 is doing a lot of clean-up on both Architecture-x64 and Architecture-x86.  These clean-ups are making both file looking so similar that they should probably be just one file in which we have a few macros to account for the differences.
Depends on: 1112164
I moved all the -x86-shared.{cpp,h} into theit own directory using
"git-mv". and then modified the files such that the include are working
properly.
Attachment #8585552 - Flags: review?(jdemooij)
Comment on attachment 8585552 [details] [diff] [review]
part 1 - Move all x86-shared files into their own directory.

Review of attachment 8585552 [details] [diff] [review]:
-----------------------------------------------------------------

Yes this makes sense.

::: js/src/jit/x86-shared/Assembler-x86-shared.h
@@ +5,4 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #ifndef jit_shared_Assembler_x86_shared_h
>  #define jit_shared_Assembler_x86_shared_h

s/jit_shared_/jit_x86_shared_/ for all header files in x86-shared.
Attachment #8585552 - Flags: review?(jdemooij) → review+
(part 1) https://hg.mozilla.org/integration/mozilla-inbound/rev/87a4a036587c

leave-open, as we should factor other common parts into this shared directory now.
Keywords: leave-open
Attachment #8586749 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/72368655a2d5
Assignee: nobody → nicolas.b.pierron
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.