1134626 - Clean-up: Share Architecture code of x86 & x64.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

Bug 1112164 is doing a lot of clean-up on both Architecture-x64 and Architecture-x86.  These clean-ups are making both file looking so similar that they should probably be just one file in which we have a few macros to account for the differences.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: part 1 - Move all x86-shared files into their own directory.

I moved all the -x86-shared.{cpp,h} into theit own directory using
"git-mv". and then modified the files such that the include are working
properly.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8585552 [details] [diff] [review]
part 1 - Move all x86-shared files into their own directory.

Review of attachment 8585552 [details] [diff] [review]:
-----------------------------------------------------------------

Yes this makes sense.

::: js/src/jit/x86-shared/Assembler-x86-shared.h
@@ +5,4 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #ifndef jit_shared_Assembler_x86_shared_h
>  #define jit_shared_Assembler_x86_shared_h

s/jit_shared_/jit_x86_shared_/ for all header files in x86-shared.

Comment 3

[Nicolas B. Pierron [:nbp]]

(part 1) https://hg.mozilla.org/integration/mozilla-inbound/rev/87a4a036587c

leave-open, as we should factor other common parts into this shared directory now.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87a4a036587c

Comment 5

[Nicolas B. Pierron [:nbp]]

Attachment: part 2 - Move x86 & x64 Architecture into a shared file.

Comment 6

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72368655a2d5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72368655a2d5