Conditionally compile the aurora update notification code

RESOLVED FIXED

Status

()

Firefox for iOS
Build & Test
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Looks like we can use simple preprocessing inside swift code to conditionally include bits of code. We can use this to only include the update tester in the Aurora build.
(Assignee)

Comment 1

3 years ago
Created attachment 8566619 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/162
Attachment #8566619 - Flags: review?(nalexander)
Comment on attachment 8566619 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/162

stefan and I discussed this in person.  One request: fold the #if clauses into an AppConstants.swift file for future code inspection.  It's stefan's choice if that happens now or in the near future.
Attachment #8566619 - Flags: review?(nalexander) → review+
(Assignee)

Comment 3

3 years ago
Fixed with https://github.com/mozilla/firefox-ios/pull/162

Reviewed in person with :nalexander during work week.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.