Closed
Bug 1134735
Opened 9 years ago
Closed 9 years ago
Don't use tee->InitAsync in nsHttpChannel::InstallCacheListener when using cache2
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
(Whiteboard: [mem-shrink])
Attachments
(1 file)
|
1.57 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
There is no need since the cache output stream is a fully buffered blocking socket (that tho never blocks) that can be easily used on the main thread. We also save memory copying at http://hg.mozilla.org/mozilla-central/annotate/986e840a2979/xpcom/io/nsInputStreamTee.cpp#l79
|
Assignee | |
Comment 1•9 years ago
|
||
Tested using an opt build and an sdcard. No UI slowdown at all. We had to do this from the start :(
Attachment #8566718 -
Flags: review?(michal.novotny)
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [mem-shrink]
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8566718 [details] [diff] [review] v1 https://treeherder.mozilla.org/#/jobs?repo=try&revision=98c88da66a12
|
||
Updated•9 years ago
|
Attachment #8566718 -
Flags: review?(michal.novotny) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc84d6942d94
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bc84d6942d94
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•