Closed
Bug 1134743
Opened 10 years ago
Closed 10 years ago
javascript filter should escape unicode line and paragraph separators (causes "Unterminated string literal" javascript error)
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: djf, Assigned: glob)
Details
Attachments
(1 file)
|
658 bytes,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
Bug 1133997 does not display correctly. The JS console shows errors while it is loading. The bug summary is not correctly displayed, but instead shown as if the bug is being edited. Some other aspects of the bug display are also slightly off. Including whatever code turns bugzilla :names into email addresses.
I've seen other recently-filed bugs with the same problem, but I was able to successfully add comments and close them.
See also bug 1133993 and bug 1133998. They both have the same problem of not showing the bug summary line property and complaining of unterminated string literals when loading.
|
Reporter | |
Comment 1•10 years ago
|
||
Candice,
You were the one who filed each of these bugs. Did you use any special tool to file them, or notice anything strange when doing it?
Flags: needinfo?(cserran)
those summaries all have a U+2028 "line separator" character in it, which is breaking the javascript.
we should be escaping those (as well as U+2029 "paragraph separator").
Assignee: nobody → glob
Component: General → User Interface
OS: Mac OS X → All
Product: bugzilla.mozilla.org → Bugzilla
QA Contact: default-qa
Hardware: x86 → All
Summary: "Unterminated string literal" and other JS errors when loading bug 1133997 → javascript filter should escape uncode line and paragraph separators (causes "Unterminated string literal" javascript error)
Target Milestone: --- → Bugzilla 5.0
Version: Production → 4.2
Attachment #8566953 -
Flags: review?(dylan)
|
||
Comment 4•10 years ago
|
||
I cloned the bugs that were on the same meta and just updated the blocking dependency fields
Flags: needinfo?(cserran)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8566953 [details] [diff] [review]
1134743_1.patch
Review of attachment 8566953 [details] [diff] [review]:
-----------------------------------------------------------------
r=dylan
also
☃=♥
Attachment #8566953 -
Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
a3da37a..88e4275 master -> master
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
d73a35c..59fcd31 5.0 -> 5.0
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: approval5.0+
Flags: approval+
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Summary: javascript filter should escape uncode line and paragraph separators (causes "Unterminated string literal" javascript error) → javascript filter should escape unicode line and paragraph separators (causes "Unterminated string literal" javascript error)
|
||
Comment 7•10 years ago
|
||
Shouldn't this be ported back to 4.4/4.2 as well?
|
||
Comment 8•10 years ago
|
||
Shouldn't this be ported back to 4.4 as well?
Flags: needinfo?(glob)
Flags: needinfo?(dylan)
(In reply to Andre Klapper from comment #8)
> Shouldn't this be ported back to 4.4 as well?
can do 4.4:
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
42ae6d0..85c1d41 4.4 -> 4.4
Flags: needinfo?(glob)
Flags: needinfo?(dylan)
Flags: approval4.4+
Target Milestone: Bugzilla 5.0 → Bugzilla 4.4
You need to log in
before you can comment on or make changes to this bug.
Description
•