1134774 - when deleting a data series from perfherder graphs, all other data series which are unchecked/muted become visible

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

when we mute a dataseries in perfherder, it works as one would expect.  The problem is when we delete a data series from the list, all the other series which are muted become visible.  

this is also the case when changing the date range (say from 14 days -> 7 days, or vice versa).

Comment 1

[Vikas Mishra [:mishravikas]]

Thanks for reporting this Joel, I'll take this one.

Comment 2

[William Lachance (:wlach)]

I suspect the easiest way to fix this would be to persist muting state in the URL somehow, maybe by incorporating it into the seriesList parameter:

https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/perf.js#L272

Comment 3

[William Lachance (:wlach)]

Note that bug 1134875 will make the above strategy somewhat easier to implement (once it lands).

Comment 4

[Vikas Mishra [:mishravikas]]

Attachment: https://github.com/mozilla/treeherder-ui/pull/398

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8572139 [details] [review]
https://github.com/mozilla/treeherder-ui/pull/398

Mostly works, however there's a problem with the series selector. Also, I think we might want to fix bug 1139204 and adjust the patch here to just modify the URL -- it's pretty annoying having the UI flash every time you toggle a series.

I will look into bug 1139204 tomorrow, it should be doable...

Comment 6

[Vikas Mishra [:mishravikas]]

Attachment: Update pr

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/e537cfc2c2b249981a077c654c6aba70d4858962
Bug 1134774 - Show/Hide series state now persists on url

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8572139 [details] [review]
https://github.com/mozilla/treeherder-ui/pull/398

Looks good now!

Comment 9

[William Lachance (:wlach)]

I think we can close this, thanks for the patch Vikas!

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/431eabdd9a7cffc86c9b5dbb045cb4f6a62ba59b
Bug 1134774 - Show/Hide series state now persists on url