Closed Bug 1134792 Opened 7 years ago Closed 7 years ago

Search suggestions horizontal UI

Categories

(Firefox for iOS :: Home screen, defect)

All
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
We need to change the search suggestion UI to be a horizontal list of items as shown at https://mozilla.invisionapp.com/share/EG26NE528#/screens/61771897?maintainScrollPosition=false.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attached file Pull request
WIP patch that creates a scrollable suggestion row. Darrin, I know you were still trying to figure out whether we want a scrollable or wrapping suggestion list, so hopefully it'll help to get an early feel for it.
Attachment #8571107 - Flags: feedback?(dhenein)
Comment on attachment 8571107 [details] [review]
Pull request

Comments in https://github.com/mozilla/firefox-ios/pull/191.
Attachment #8571107 - Flags: feedback?(dhenein) → feedback-
Comment on attachment 8571107 [details] [review]
Pull request

Updated to use a wrapping flow layout instead of a scrollable one.
Attachment #8571107 - Flags: review?(sarentz)
Attachment #8571107 - Flags: feedback?(dhenein)
Attachment #8571107 - Flags: feedback-
Comment on attachment 8571107 [details] [review]
Pull request

LGTM
Attachment #8571107 - Flags: review?(sarentz) → review+
Comment on attachment 8571107 [details] [review]
Pull request

Merged.
Attachment #8571107 - Flags: feedback?(dhenein)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.