Closed
Bug 1134795
Opened 9 years ago
Closed 9 years ago
[User Story] See app icon when installing web app from page
Categories
(Firefox OS Graveyard :: Gaia::Bookmark, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
2.2 S9 (3apr)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: benfrancis, Assigned: benfrancis)
References
Details
(Keywords: feature, Whiteboard: [systemsfe])
User Story
As a user I want to see the icon of a web app when installing it from a web page. Acceptance Criteria: 1. Icon parsing matches W3C spec: http://w3c.github.io/manifest/#icons-member 2. The display of the icon meets the UX spec IxD - Francis https://mozilla.box.com/s/fhlmfa4xyooqpwaaaczc VxD - Eric Spec https://mozilla.app.box.com/s/fnuq2vthajkvodwemrq1
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Note to self: May need to duplicate some of the icon processing code from Gecko as there's currently no API to get an icon for an app which isn't installed http://lxr.mozilla.org/mozilla-central/source/dom/manifest/ManifestProcessor.jsm#219
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bfrancis
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attached WIP patch, just needs integration test.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8580908 [details] [review] [gaia] benfrancis:1134795 > mozilla-b2g:master Added a basic integration test. Cristian, any chance of a review on this? For the initial implementation I think we need to duplicate a little manifest parsing logic from Gecko, until we figure out what new APIs to add to do some of these things. This patch adds a parser for the icons property to WebManifestHelper and shows the icon on the add to homescreen dialog.
Attachment #8580908 -
Flags: review?(crdlc)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8580908 [details] [review] [gaia] benfrancis:1134795 > mozilla-b2g:master LGTM and a great good job as always. I gave a couple of comments if you want to take in account. Most of them are nice to have so r+. Thanks a lot Ben
Attachment #8580908 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Addressed review comments, thanks Cristian.
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 7•9 years ago
|
||
Not sure why autolander didn't do this, but https://github.com/mozilla-b2g/gaia/commit/0aff881387299aa1ae8b98364905c2789b1385a9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
status-b2g-master:
--- → fixed
Target Milestone: --- → 2.2 S9 (3apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•