Closed Bug 1134801 Opened 5 years ago Closed 5 years ago

[P2P Sharing] Toggle sharing of individual apps/add-ons

Categories

(Firefox OS Graveyard :: Gaia::P2P Sharing, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: drs, Assigned: drs)

References

Details

(Whiteboard: [spark])

Attachments

(2 files)

Currently, the toggles for sharing individual apps and add-ons are stubs, and the only user setting that is respected is whether or not sharing is enabled in general. We must implement toggling of sharing individual apps/add-ons.
Status: NEW → ASSIGNED
Let's get this part reviewed before going further.
Attachment #8580262 - Flags: review?(jdarcangelo)
Keywords: leave-open
Comment on attachment 8580262 [details] [review]
Part 1: service refactors.

Almost there. Just a few minor issues in the GH comments. All in all, this is a huge improvement.
Attachment #8580262 - Flags: review?(jdarcangelo) → review-
Comment on attachment 8580262 [details] [review]
Part 1: service refactors.

Ready for the next iteration.
Attachment #8580262 - Flags: review- → review?(jdarcangelo)
Comment on attachment 8580262 [details] [review]
Part 1: service refactors.

One minor nit about removing `/* exported ActivityService */` because I don't think the linter will complain about it anymore. Otherwise, LGTM.
Attachment #8580262 - Flags: review?(jdarcangelo) → review+
Attachment #8580262 - Attachment is patch: true
Attachment #8580262 - Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8580262 - Attachment is patch: false
Attachment #8580262 - Attachment mime type: text/plain → text/x-github-pull-request
See Also: → 1145742
Comment on attachment 8580410 [details] [review]
Part 2: Toggle sharing of individual apps/add-ons.

Looks good. One minor nit from me and you also have a comment to yourself to add a reject callback in http_server_service.js.
Attachment #8580410 - Flags: review?(jdarcangelo) → review+
Comment on attachment 8580410 [details] [review]
Part 2: Toggle sharing of individual apps/add-ons.

Landed with code review comment fixes.
https://github.com/fxos/sharing/commit/830c4cc39f3cedf4bd3e76aec24152857621fdd8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
Component: Gaia → Gaia::P2P Sharing
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.