Closed Bug 1134876 Opened 7 years ago Closed 7 years ago

functionCalls is null when clicking on a recording that could not load/loading

Categories

(DevTools Graveyard :: Canvas Debugger, defect)

37 Branch
x86
macOS
defect
Not set
normal

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

When clicking on the snapshot list item of a recording that has no rAF cycle, this throws. Even after refactoring and allowing timeouts in bug 985488 this occurs.

A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Thu Feb 19 2015 14:50:14 GMT-0800 (PST)
Full Message: TypeError: functionCalls is null
Full Stack: CallsListView<.showCalls@chrome://browser/content/devtools/canvasdebugger.js:602:21
SnapshotsListView<._onSelect/<@chrome://browser/content/devtools/canvasdebugger.js:330:7
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:37
Depends on: 985488
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Once rebased etc, simple fix:

SnapshotsList._onSelect: function () {                                            
  if (!snapshotItem || !snapshotItem.attachment.actor) {
    return;
  }
...
Attached patch 1134876-canvasbugs.patch (obsolete) — Splinter Review
try's down.
Attachment #8568610 - Flags: review?(vporof)
Comment on attachment 8568610 [details] [diff] [review]
1134876-canvasbugs.patch

Review of attachment 8568610 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/canvasdebugger/snapshotslist.js
@@ +161,5 @@
>    /**
>     * The select listener for this container.
>     */
>    _onSelect: function({ detail: snapshotItem }) {
> +    if (!snapshotItem || !snapshotItem.attachment.actor) {

Maybe add a comment here describing how the actor can be null for in-progress recordings.
Attachment #8568610 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/44bc0ab3e491
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.