Closed
Bug 1134884
Opened 11 years ago
Closed 11 years ago
Log room conection identifier
Categories
(Hello (Loop) :: Server, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: abr, Assigned: rhubscher)
Details
(Whiteboard: [loop-metrics])
Attachments
(1 file)
Currently, when analyzing server logs, there is no good way to identify which messages came from which client. While we don't need correlation across sessions, the ability to distinguish which of the multiple clients connected to a room sent which message is necessary.
The rooms design already has an identifier that maps to exactly the concept we want, called "roomConnectionId." See https://wiki.mozilla.org/Loop/Architecture/Rooms#User_Identification_in_a_Room
This field should be logged in all requests logged for /rooms/<token> to allow for this correlation.
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [loop-metrics]
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → rhubscher
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8574644 -
Flags: review?(mathieu)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8574644 [details] [review]
Link to Github PR — #311.
https://github.com/mozilla-services/loop-server/commit/c7e3b316805096d5b3185655c42cae048ed06091
Attachment #8574644 -
Flags: review?(mathieu) → review+
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•