1134918 - [Search] lines between history are off screen and makes the screen scrollable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20150219_SearchScreenOff.txt

Description:
When there are multiple items under HISTORY on the search result screen, the divider lines are shifted off the screen to the right. This makes the search screen horizontally scrollable to the right.

Repro Steps:
1) Update a Flame to 20150219010228
2) Enable Wi-Fi or data connection, and navigate to different websites to generate browser history. There has to be enough pages, so the search results displays more than 1 item under HISTORY.
3) Tap the search bar, and enter 1 or 2 letters to bring browser history under HISTORY.

Actual:
The dividers are shifted off the screen, and the screen can be scrolled to the right.

Expected:
The dividers are not shifted, and the search screen is NOT scrollable.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150219010228
Gaia: 620aecfde85a8b093247837c55de2708e22be1e1
Gecko: 360b5f211180
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 5/5
See attached: logcat, video
http://youtu.be/WXt3H3OD0Po

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduces on Flame 2.2.

Result: The search result screen is not scrollable.

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150219002504
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: 159a3907b959
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

This is a regression so nominating 3.0? Let's get a regression window.

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Comment 4

[Yeojin Chung [:YeojinC]]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150218070906
Gaia: 6875a6ac9bcfacc5a7d97fc7a6839105dfeeb9e2
Gecko: b66abf148c10
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150218074758
Gaia: db44e23e519094bf3db9b733f8f632689fdb20d1
Gecko: 3f5e549ddee9
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: 6875a6ac9bcfacc5a7d97fc7a6839105dfeeb9e2
Gecko: 3f5e549ddee9

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: db44e23e519094bf3db9b733f8f632689fdb20d1
Gecko: b66abf148c10

https://github.com/mozilla-b2g/gaia/compare/6875a6ac9bcfacc5a7d97fc7a6839105dfeeb9e2...db44e23e519094bf3db9b733f8f632689fdb20d1

caused by bug 1129701

Comment 5

[Gregor Wagner [:gwagner]]

Bug 1129701 is now uplifted and it should break 2.2 as well. Can we test 2.2 again?

Comment 6

[Yeojin Chung [:YeojinC]]

(In reply to Gregor Wagner [:gwagner] from comment #5)
> Bug 1129701 is now uplifted and it should break 2.2 as well. Can we test 2.2
> again?

Yes, it is now affected in 2.2 as well.

Result: The dividers are shifted off the screen, and the screen can be scrolled to the right.

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150220002501
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: b864abe1c6b3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 7

[KTucker [:KTucker][Inactive 3/4/2016]]

Ahmed, can you take a look at this please? Looks like the landing and recent uplift for Bug 1129701 might have caused this to occur.

Comment 8

[Kevin Grandon :kgrandon]

Fixed by backing out bug 1129701.

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly 3.0 and 2.2 builds
	
Actual results:  The bars between search terms are positioned correctly.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150226010233
Gaia: 7894b929f1b0394f3c997f72a6482bc7813e758d
Gecko: dd6353d61993
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150226002503
Gaia: bf24aa57fa7760260ab05d1f53242c8d8ae59e83
Gecko: 363123044e61
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0