Closed
Bug 1134944
Opened 9 years ago
Closed 9 years ago
Move getSummaryFile to folder so that maildir can be selected in imap mail setup
Categories
(MailNews Core :: Backend, defect)
Tracking
(thunderbird38+ fixed)
RESOLVED
FIXED
Thunderbird 39.0
People
(Reporter: rkent, Assigned: rkent)
Details
Attachments
(1 file)
17.56 KB,
patch
|
jcranmer
:
review+
rkent
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
This bug is a followup to bug 1096006. Although UI was added to account setup in that bug, that UI is already disabled when you reach advanced account setup. By moving getSummaryFile to the folder, when we make maildir setup work for imap setup.
Assignee | ||
Comment 1•9 years ago
|
||
Sorry, this is a followup to bug 1124015.
Assignee | ||
Comment 2•9 years ago
|
||
This is the same patch as bug 1124015 part 1
Assignee | ||
Updated•9 years ago
|
tracking-thunderbird38:
--- → +
Comment 3•9 years ago
|
||
Comment on attachment 8566923 [details] [diff] [review] move getSummaryFile to folder Review of attachment 8566923 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/base/public/nsIMsgFolder.idl @@ +454,5 @@ > */ > attribute nsIFile filePath; > > + /// an nsIFile corresponding to the .msf file. > + readonly attribute nsIFile summaryFile; I wonder if this wouldn't be better named "databaseFile" ?
Attachment #8566923 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Joshua Cranmer [:jcranmer] from comment #3) > Comment on attachment 8566923 [details] [diff] [review] > move getSummaryFile to folder > > Review of attachment 8566923 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mailnews/base/public/nsIMsgFolder.idl > @@ +454,5 @@ > > */ > > attribute nsIFile filePath; > > > > + /// an nsIFile corresponding to the .msf file. > > + readonly attribute nsIFile summaryFile; > > I wonder if this wouldn't be better named "databaseFile" ? I'm afraid that ship has sailed, and summaryFile is now in fairly common usage in mailnews code. Renaming it now would only create confusion.
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/18c31acd69e5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8566923 [details] [diff] [review] move getSummaryFile to folder Approval Request Comment [Feature/regressing bug #]: none [User impact if declined]: maildir cannot be chosen during new account setup [Describe test coverage new/current, TreeHerder]: general tests cover this [Risks and why]: Low, merely moves functionality up one level in the hierarchy [String/UUID change made/needed]: UUID changed, we have agreed that UUID is not yet frozen in aurora. I'll approve and push this after watchin the c-c landing.
Attachment #8566923 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8566923 [details] [diff] [review] move getSummaryFile to folder since this landed to comm-central, you probably meant to set the approval-comm-aurora flag instead.
Attachment #8566923 -
Flags: approval-mozilla-aurora? → approval-comm-aurora?
Assignee | ||
Updated•9 years ago
|
Attachment #8566923 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/90580bc940ab
status-thunderbird38:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•