1134968 - JS_NewObjectWithGivenProto will happily create null-parent objects if you pass in a null proto

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Unlike JS_NewObject, which will default null parent to the global, JS_NewObjectWithGivenProto defaults it to the parent of the proto, if there is a proto.  If not, it leaves it null.

We should probably default it to the global instead.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: If JS_NewObjectWithGivenProto is passed a null parent and null proto, use the context's current global as the parent

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5dabb5e547e8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5dabb5e547e8