Closed Bug 1135007 Opened 5 years ago Closed 5 years ago

"Sync Now" button is not translated

Categories

(Firefox for Android :: Android Sync, defect)

Firefox 36
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 39
Tracking Status
firefox36 --- wontfix
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: xshen, Assigned: yfdyh000, Mentored)

References

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(2 files)

148.74 KB, image/png
Details
57 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review
Attached image screenshot1
Steps:
1)Install Fennec V36.0 for zh-CN(ftp://ftp.mozilla.org/pub/mobile/candidates/36.0-candidates/build1/android/zh-CN/) and choose language in the device settings as "Simplified Chinese".

2)Launch Fennec and setup Sync account successfully. 

3)Go to System Settings -> Account -> Firefox Account -> Click on your Sync account, then uncheck Sync. (see screenshot1.)

4)Launch Fennec and go to settings->Sync, there is an error message. Observe the “Sync now" button. It's in zh-CN. Back to settings then go to Sync again, "Sync now" button is displayed in English. 

Device:
Samsung S4
Assignee: nobody → shaohua.wen
Component: General → zh-CN / Chinese (Simplified)
Product: Firefox for Android → Mozilla Localizations
QA Contact: shaohua.wen
Version: Firefox 36 → unspecified
No "Sync Now" strings is not localized in zh-CN locale.
http://transvision.mozfr.org/?recherche=Sync+Now&repo=release&sourcelocale=en-US&locale=zh-CN&search_type=strings&perfect_match=perfect_match


Perhaps is the http://hg.mozilla.org/mozilla-central/annotate/5f1009731a97/mobile/android/base/resources/xml/fxaccount_status_prefscreen.xml#l63
Assignee: shaohua.wen → nobody
Component: zh-CN / Chinese (Simplified) → General
Product: Mozilla Localizations → Firefox for Android
QA Contact: shaohua.wen
Version: unspecified → Firefox 36
Blocks: 966103
Component: General → Android Sync
Product: Firefox for Android → Android Background Services
Oops.  We have the entity at [1] and the string at [2], we're just not using it in the prefs XML.  (We are using it later, in code.)  Perfect first bug!

[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/sync_strings.dtd#201

[2] https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/strings.xml.in#190
Mentor: nalexander, vivekb.balakrishnan
Whiteboard: [lang=java][good first bug]
Summary: "Sync Now" button is not translated to zh-CN in zh-CN build. → "Sync Now" button is not translated
Attached file Github Pull Request
Attachment #8567764 - Flags: review?(nalexander)
Comment on attachment 8567764 [details] [review]
Github Pull Request

Looks good.  I'll land this and request uplift.
Attachment #8567764 - Flags: review?(nalexander) → review+
Status: NEW → ASSIGNED
Flags: needinfo?(yfdyh000)
Comment on attachment 8567764 [details] [review]
Github Pull Request

Approval Request Comment
[Feature/regressing bug #]: Bug 966103.
[User impact if declined]: untranslated string.
[Describe test coverage new/current, TreeHerder]: it builds.
[Risks and why]: almost none.
[String/UUID change made/needed]: None, the string already existed.
Attachment #8567764 - Flags: approval-mozilla-aurora?
Comment on attachment 8567764 [details] [review]
Github Pull Request

Approval Request Comment
[Feature/regressing bug #]: Bug 966103.
[User impact if declined]: untranslated string.
[Describe test coverage new/current, TreeHerder]: it builds.
[Risks and why]: almost none.
[String/UUID change made/needed]: None, the string already existed.
Attachment #8567764 - Flags: approval-mozilla-beta?
Release managers: this is trivial.  It would be nice to get it all the way up to 36 (well, 37, I guess); do as you will.
36 is just about to ship so we missed the boat. We can possibly take this as a ride along in a point release if one is required.
Comment on attachment 8567764 [details] [review]
Github Pull Request

This is certainly trivial. Let's get this into 37 Beta 1. I've cleared the Aurora approval as Aurora is now 38.

Beta+
Attachment #8567764 - Flags: approval-mozilla-beta?
Attachment #8567764 - Flags: approval-mozilla-beta+
Attachment #8567764 - Flags: approval-mozilla-aurora?
This missed the uplift, so it's going to have to land on Aurora as well.
https://hg.mozilla.org/mozilla-central/rev/06c2717a9cc5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Attachment #8567764 - Flags: approval-mozilla-aurora?
Comment on attachment 8567764 [details] [review]
Github Pull Request

Aurora+ to land in 38.
Attachment #8567764 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.