If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

SIMD: Generalize shifts

RESOLVED FIXED in Firefox 40

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

Trunk
mozilla40
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Same as bug 1135039, but for shifts.
(Assignee)

Updated

3 years ago
Flags: needinfo?(benj)
(Assignee)

Comment 1

3 years ago
For the shift parts.
Depends on: 1112627
(Assignee)

Comment 2

3 years ago
Created attachment 8580060 [details] [diff] [review]
shifts.patch
Assignee: nobody → benj
Status: NEW → ASSIGNED
Attachment #8580060 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8580060 [details] [diff] [review]
shifts.patch

Review of attachment 8580060 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/shared/CodeGenerator-x86-shared.cpp
@@ +3135,1 @@
>      // lanes by default for lsh and ursh, and set the count to 32 for rsh

nit: and set the count to 32 for rsh
                          ^
                           \- 31 ?

Also, I think the important fact is what is in between parenthesis below, as this is the returned value, and not a non-observable intermediate value in-between.
Attachment #8580060 - Flags: review?(nicolas.b.pierron) → review+
(Assignee)

Comment 4

3 years ago
Thanks! Fixed the comment, it makes indeed more sense to talk about the returned value rather than the intermediate one.

Landing is blocked by bug 1112627.
(Assignee)

Updated

3 years ago
Flags: needinfo?(benj)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aca5bc01ad8
https://hg.mozilla.org/mozilla-central/rev/3aca5bc01ad8
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.