Open Bug 1135043 Opened 9 years ago Updated 2 years ago

create better syntax for GENERATED_FILES

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(Not tracked)

People

(Reporter: froydnj, Unassigned)

References

Details

When reviewing bug 1134633, mshal suggested that the currently-required syntax for GENERATED_FILES, where one actually wants to express code generation:

GENERATED_FILES += ['foo']
f = GENERATED_FILES['foo']
f.script = ...

is sort of ugly and redundant.  It'd be much nicer if we had something like:

f = GENERATED_FILES.add('foo')
f.script = ...

It looks like none of Python's built-in list methods (which are available on GENERATED_FILES AFAICS) actually return the newly-appended/extended/inserted thing; hence the need for a new method.
We may want to utilize bug 1134072 for GENERATED_FILES.
per bug 1160185 comment 4, that'd be something like:

with GeneratedFile('foo'):
    SCRIPT = ...
    ENTRY_POINT = ...
    INPUTS = ....
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.