Closed Bug 1135056 Opened 11 years ago Closed 5 years ago

Tag allocating nsTArray functions with*_WARN_UNUSED_RESULT

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: gcp, Unassigned)

References

Details

Currently it's possible for code to be using FallibleTArrays without checking the results (for failed allocations). This is almost always a bug. GCC supports tagging functions and automatically generating warnings for this, so we should use those annotations.
Depends on: 968520
The patches in bug 968520 will include this, but leaving open for now.
Assignee: nobody → birunthan
Unassigning to cleanup Bugzilla dashboard. Will make sure this gets done after bug 968520 is resolved.
Assignee: birunthan → nobody

We have tagged everything with [[nodiscard]] nowadays; if that's not sufficient, please file another bug.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.