Testopia must set PUBLIC_METHODS for its WebServices to work

RESOLVED FIXED in 3.0

Status

Testopia
API
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: f1sh, Assigned: f1sh)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
A commit introduced by bug 1090275 has resulted in all Testopia API calls not working. I'm currently working on a patch.
(Assignee)

Comment 1

3 years ago
Created attachment 8567143 [details] [diff] [review]
patch.diff

PUBLIC_METHODS have been added to every Testopia lib/WebService file
Attachment #8567143 - Flags: review?(dylan)
(Assignee)

Updated

3 years ago
Assignee: gregaryh → theycallmefish
Status: NEW → ASSIGNED

Comment 2

3 years ago
With this patch, we have enough critical stuff to release Testopia 2.6 soon.
Summary: Security fix introduced in Bugzilla 4.4.7 broke API calls → Testopia must set PUBLIC_METHODS for its WebServices to work
Target Milestone: --- → 2.6
(Assignee)

Comment 3

3 years ago
(In reply to Frédéric Buclin from comment #2)
> With this patch, we have enough critical stuff to release Testopia 2.6 soon.

I agree. With this fix's completion, Testopia retains compatibility with Bugzilla 5.0
(Assignee)

Comment 4

3 years ago
Comment on attachment 8567143 [details] [diff] [review]
patch.diff

Changing reviewer, as LpSolit has handled Testopia updates for me in the past.

Once this has been pushed, we should package all the changes up to this point as a new Testopia release.
Attachment #8567143 - Flags: review?(dylan) → review?(LpSolit)

Comment 5

3 years ago
(In reply to Ryan Wilson [:f1sh] from comment #4)
> Once this has been pushed, we should package all the changes up to this
> point as a new Testopia release.

ghendricks told me that he no longer has access to the Testopia repo since they moved to git. :)
(Assignee)

Comment 6

3 years ago
(In reply to Frédéric Buclin from comment #5)
> (In reply to Ryan Wilson [:f1sh] from comment #4)
> > Once this has been pushed, we should package all the changes up to this
> > point as a new Testopia release.
> 
> ghendricks told me that he no longer has access to the Testopia repo since
> they moved to git. :)

What is the best course of action moving forward? Do we work on getting ghendricks access to the repo, or does someone else take over?

Comment 7

3 years ago
No idea who manages git accounts.

Comment 8

3 years ago
I cannot really test this patch, because I get a lot of errors already, using Bugzilla 4.4.8. Ryan, could you test/confirm something for me?

Click the "Current Runs" in the page footer, then double-click on a run, then click on the select box for the "Build" field. I get this error:

There was an error loading the data: {"message":"Missing required parameter product_id","error":"testopia-missing-parameter","success":false}

I get the same error with the "Environment" select box.

I also get the same error under "My Cases" for the "Category" field.
(Assignee)

Comment 9

3 years ago
(In reply to Frédéric Buclin from comment #8)
> I cannot really test this patch, because I get a lot of errors already,
> using Bugzilla 4.4.8. Ryan, could you test/confirm something for me?
> 
> Click the "Current Runs" in the page footer, then double-click on a run,
> then click on the select box for the "Build" field. I get this error:
> 
> There was an error loading the data: {"message":"Missing required parameter
> product_id","error":"testopia-missing-parameter","success":false}
> 
> I get the same error with the "Environment" select box.
> 
> I also get the same error under "My Cases" for the "Category" field.

I am seeing these errors too, though I'm not sure if this was an issue in Bugzilla 4.4.6 without the patch (I have this patch in place on BNC, and haven't heard this error from any of our heavy Testopia users). I'll have to create these conditions in a test environment and try it out. If it is, I'll create a new bug to fix this and consider it a blocker for a Testopia 2.6 release.
(Assignee)

Comment 10

3 years ago
If this issue does not exist in 4.4.6 without the patch, then we can mark the patch '-'
(Assignee)

Comment 11

3 years ago
This issue does exist prior to the patch. Assuming everything else is fine with the patch, it should be okay to '+'.

I will create another bug for the issue brought up in comment 8

Comment 12

3 years ago
Comment on attachment 8567143 [details] [diff] [review]
patch.diff

I didn't make sure that every method is listed in PUBLIC_METHODS. I assume you already checked that. r=LpSolit
Attachment #8567143 - Flags: review?(LpSolit) → review+

Comment 13

3 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/extensions/Testopia.git
   2f5a32c..d68ed0c  master -> master
Severity: normal → critical
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → 2.5
(Assignee)

Comment 14

3 years ago
(In reply to Frédéric Buclin from comment #12)
> Comment on attachment 8567143 [details] [diff] [review]
> patch.diff
> 
> I didn't make sure that every method is listed in PUBLIC_METHODS. I assume
> you already checked that. r=LpSolit

I made sure all methods were accounted for.
You need to log in before you can comment on or make changes to this bug.