113508 - Identical URIs do not compare via nsIURI::Equals

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Adam Lock]

If I create a new URI object (e.g. via NS_NewURI) from "http://cnn" and another
from "http://cnn/", they both become a URI with a "http://cnn/" spec but calling
uri1->Equal(uri2, &isEqual) returns PR_FALSE.

It looks like that trailing slash on the input screws up how mBasename is
calculated, so when they are compared, the URLSegments differ. In particular
mBasename.mLen is -1 in the first and 0 in the second. 

Aside from being wrong it may impact the performance of the cache and other areas.

Comment 1

[Adam Lock]

Attachment: PR log file demonstrates the different URL segments for two equal URIs

Search for "http://cnn" to see the difference that the trailing slash makes on
how the URI is stored and comparisons are made.

Comment 2

[Darin Fisher]

the cache actually just uses URL strings not URL objects to differentiate cache
entries, so this bug shouldn't impact caching.  however, this bug is still very
critical IMO.

-> 0.9.7

Comment 3

[Adam Lock]

Attachment: Smaller log with the two URIs side by side

Comment 4

[Darin Fisher]

Attachment: v1.0 patch

this patch fixed the problem.  ran url parsing tests w/ this patch applied and
didn't notice any regressions.

Comment 5

[Darin Fisher]

andreas: can i get an r= from you on the v1.0 patch?  thx!

Comment 6

[rpotts (gone)]

Comment on attachment 60398 [details] [diff] [review]
v1.0 patch

sr=[e-mail]

Comment 7

[Andreas Otte]

Comment on attachment 60398 [details] [diff] [review]
v1.0 patch

r=[e-mail]

Comment 8

[Darin Fisher]

fixed-on-trunk