Closed Bug 1135085 Opened 9 years ago Closed 9 years ago

After bug 1022600 no icon in tab for inContent prefs

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird38 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 39.0
Tracking Flags:
Tracking Status
thunderbird38 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

prefTabIcon.patch
2.03 KB, patch
jsbruner
: review+
Sylvestre
: approval-comm-aurora+
Details | Diff | Splinter Review 
Bug 1022600 changed the icon from png to svg. We need to follow this for the inContnet prefs.
Change from png to svg. At the same time I changed from "shortcut icon" in XUL to a CSS definition in shared tabmail.css. This makes it easier for 3rd party themers to use their own icon and position where it is stored.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8567133 - Flags: review?(josiah)
Attachment #8567133 - Flags: review?(josiah) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/e8602397e377 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
Comment on attachment 8567133 [details] [diff] [review]
prefTabIcon.patch

[Approval Request Comment]
Regression caused by (bug #): 1135085
User impact if declined: No icon in prefs tab.
Testing completed (on c-c, etc.): in c-c
Risk to taking this patch (and alternatives if risky): low, it's a simple XUL/CSS patch.
Attachment #8567133 - Flags: approval-comm-aurora?
Attachment #8567133 - Flags: approval-comm-aurora? → approval-comm-aurora+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: