1135195 - [RTL][Notifications] Review transfer request notifications have vertically overlapping text when in Arabic but receiving a transfer from a English named bluetooth device.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P1)

Description

[Joshua Mitchell (Inactive)]

Attachment: 2015-02-20-10-22-10.png

Description:
When in an RTL language (Arabic) and receiving a bluetooth transfer request from a device with an English-named bluetooth signal, the notification will have text that overlaps vertically. Basically the descenders from the English named device will overlap with the ascenders of the Arabic bluetooth message. A bluetooth name with multiple descenders will look worse.

Repro Steps:
1) Update a Flame to 20150220010206
2) Pair with another device with an English Bluetooth name (preferably with descenders) 
3) Recieve a bluetooth transfer request from the other device

Actual:
overlapping text in the notification

Expected:
no overlapping text

Environmental Variables:
Device: Flame 3.0
Build ID: 20150220010206
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: 1b4c5daa7b7a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Repro frequency: 6/6
See attached: screenshot

Comment 1

[Joshua Mitchell (Inactive)]

This issue also occurs in 2.2

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150220002501
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: b864abe1c6b3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Gregor Wagner [:gwagner]]

Overlapping text.

Comment 3

[Stephany Wilkes]

Overlapping text is a blocker to RTL ship and violates the pattern. Blocking.

Comment 4

[Gregor Wagner [:gwagner]]

Is this system or BT component?

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Adding P1 for triage purposes

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Taking.

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

This is a blocker but hasn't been worked on yet. Michael: just a gentle reminder to look into this. ni on you as a reminder. Thanks :)

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks for the reminder Delphine, I have been working on some other things.

Alberto, could you give me a hand on this one?

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1135195-rtl-notifications-bt > mozilla-b2g:master

Comment 10

[Alberto Pastor [:albertopq]]

Attachment: Screenshot with the patch

Comment 11

[Norry.L.F(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15671/

Comment 12

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8574689 [details] [review]
[gaia] albertopq:1135195-rtl-notifications-bt > mozilla-b2g:master

Thanks!

Comment 13

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 14

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/ca91e1b103a127e991217230f0b3d6083e8a2b87

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 16

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 build.

Actual Results: The device name and message text do not overlap.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150312010235
Gaia: 0c4e8b0b330757e261b031b7e7f326ef419c9808
Gecko: 5334d2bead3e
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 17

[Alberto Pastor [:albertopq]]

Comment on attachment 8574689 [details] [review]
[gaia] albertopq:1135195-rtl-notifications-bt > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: The bluetooth request notification text overlaps.
[Testing completed]: Manual testing
[Risk to taking this patch] (and alternatives if risky): CSS only change
[String changes made]: none

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/b27cc70b273d20a2a522fed348a4407da8d1d564

Comment 19

[Lancy(Leave from Mozilla)]

Attachment: Verify2_Flame2.2_Pass.png

According to the steps in comment 0, the issue has been verified pass on latest Flame 2.2 build.
See attachment:Verify2_Flame2.2_Pass.png
Reproducing rate:0/10

Flame 2.2 build:
Build ID               20150407162504
Gaia Revision          ea735c21bfb0d78333213ff0376fce1eac89ead6
Gaia Date              2015-04-07 20:58:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.195227
Firmware Date          Tue Apr  7 19:52:39 EDT 2015
Bootloader             L1TC000118D0