Consider returning ENTRY_NEEDS_REVALIDATION only when request is actually conditinal

NEW
Unassigned

Status

()

Core
Networking: Cache
P5
normal
3 years ago
4 months ago

People

(Reporter: mayhemer, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [necko-would-take])

(Reporter)

Description

3 years ago
There are scenarios we re-validate with the server (actually go to the server) based on expiration time.  However, in those cases there is no way to build any conditional request headers (no Last-Modified, no ETag in the response, no If-* custom request header as well).  Hence, we never get 304 for such a request.  Still, we block any waiting consumers for the same cache entry for such entries with returning ENTRY_NEEDS_REVALIDATION from nsHttpChannel::OnCacheEntryCheck.

Instead returning ENTRY_NEEDS_REVALIDATION when mDidReval is set, better do so only when any If-* header is set.  We are anyway going to recreate the cache entry after a non-304 response.
(Reporter)

Updated

3 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [necko-would-take]
You need to log in before you can comment on or make changes to this bug.