1135285 - Newtab is generating wrong values for the lastIndex in the view ping

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect)

Description

[Drew Willcoxon :adw]

Max noticed that gPage.reportLastVisibleTileIndex in page.js is generating wrong, strange values for lastIndex.  I see it too.  I don't know what's wrong, but it must be something about the cwu.getBoundsWithoutFlushing() or nodesFromRect().

Comment 1

[Drew Willcoxon :adw]

Bug 1042214 added the ping, bug 1071635 changed how it calculated it to cwu.getBoundsWithoutFlushing() and nodesFromRect().

Comment 2

[maxim zhilyaev]

I tested on release and beta browsers, the counting is off:

- on 3x1 - triggeringSiteIndex == 1
- on 2x2 - triggeringSiteIndex == 1
- on 4x3 - triggeringSiteIndex == 7
- on 3x3 - triggeringSiteIndex == 5
- on 4x4 - triggeringSiteIndex == 11

This causes "view" parameter of a newtab impression collected by infernyx to be wrong, and as a result our impression count could be off as well.  According to tspurway "view" logic was broken anyway on the server side, so impression counts are incorrect in general.

Comment 3

[Tim Spurway [:tspurway]]

:maksik has noticed that this bug appears to be fixed in beta.  Does this bug need to be updated?  

I believe this bug causes Bug 1135285

Comment 4

[Tim Spurway [:tspurway]]

Correction on Comment 3:


I believe this bug causes Bug 1144783

Comment 5

[Ed Lee :Mardak]

Release 36 seems to sometimes trigger view=1 on first newtab then view=7 on subsequent. Not sure if it's something related to preloading and how it might have changed with bug 1077652.

maksik, can you confirm brokeness/or-not with Release 36, Beta 37, Aurora 38, Nightly 39?

Comment 6

[maxim zhilyaev]

Works OK on

Release - 36.0.1
Beta - 37.0
Nightly - 39.0a1

The only glitch is that when newtab is clicked right after browser is resized, reportLastVisibleTileIndex corresponds to what it was before resizing, all subsequent newtab calls show correct index.
Note that reportLastVisibleTileIndex is 0 based, so if newtab shows 1 tile, the index is 0