Closed Bug 1135368 Opened 5 years ago Closed 5 years ago

shell/futex.js should be disabled on non-nightly.

Categories

(Core :: JavaScript Engine, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

futex.js tests SharedArrayBuffer, which is enabled only on nightly.
I guess the existence checking code is wrong.

> if ((this.SharedArrayBuffer && this.AtomicsObject && this.getSharedArrayBuffer && this.setSharedArrayBuffer))
>     quit(0);
Blocks: 1131953
[Tracking Requested - why for this release]: Test permafail after Monday's Aurora uplift.
Severity: normal → critical
Flags: needinfo?(lhansen)
SharedArrayBuffer is defined only on nightly.
getSharedArrayBuffer and setSharedArrayBuffer are always defined.
AtomicsObject is never defined.
So the condition is always false, and it never quits.

Removing the check for AtomicsObject, and inverting the entire condition will solve this.
(not sure it's required to check the existence of getSharedArrayBuffer and setSharedArrayBuffer, since this is a shell-only test)
Attachment #8567574 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/f9bce66211f2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Assignee: nobody → arai.unmht
Thanks for fixing this!
Flags: needinfo?(lhansen)
Depends on: 1141516
You need to log in before you can comment on or make changes to this bug.