shell/futex.js should be disabled on non-nightly.

RESOLVED FIXED in Firefox 38

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
futex.js tests SharedArrayBuffer, which is enabled only on nightly.
I guess the existence checking code is wrong.

> if ((this.SharedArrayBuffer && this.AtomicsObject && this.getSharedArrayBuffer && this.setSharedArrayBuffer))
>     quit(0);
(Assignee)

Updated

3 years ago
Blocks: 1131953
[Tracking Requested - why for this release]: Test permafail after Monday's Aurora uplift.
Severity: normal → critical
tracking-firefox38: --- → ?
Flags: needinfo?(lhansen)
(Assignee)

Comment 2

3 years ago
SharedArrayBuffer is defined only on nightly.
getSharedArrayBuffer and setSharedArrayBuffer are always defined.
AtomicsObject is never defined.
So the condition is always false, and it never quits.

Removing the check for AtomicsObject, and inverting the entire condition will solve this.
(not sure it's required to check the existence of getSharedArrayBuffer and setSharedArrayBuffer, since this is a shell-only test)
(Assignee)

Comment 3

3 years ago
Created attachment 8567574 [details] [diff] [review]
Do not run shell/futex.js test if SharedArrayBuffer is not defined.

Fixed as comment #2.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=42da6e931c3b&exclusion_state=all
Attachment #8567574 - Flags: review?(luke)

Updated

3 years ago
Attachment #8567574 - Flags: review?(luke) → review+
(Assignee)

Comment 4

3 years ago
Thank you!

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9bce66211f2
https://hg.mozilla.org/mozilla-central/rev/f9bce66211f2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Assignee: nobody → arai.unmht

Comment 6

3 years ago
Thanks for fixing this!
Flags: needinfo?(lhansen)
Depends on: 1141516
tracking-firefox38: ? → ---
You need to log in before you can comment on or make changes to this bug.