ecma_5/extensions/misplaced-inconsistent-directive.js fails on windows spidermonkey build with --baseline-eager --no-fpu.

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla39
x86_64
Windows 8
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox39 fixed, firefox-esr38 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
> ## ecma_5\extensions\misplaced-inconsistent-directive.js: rc = 3, run time = 0.031000
> 1046964: Misplaced directives (e.g. 'use strict') should trigger warnings if they contradict the actually-used semantics
> @evaluate:TypeError: asm.js type error: Disabled by lack of floating point support
> TEST-UNEXPECTED-FAIL | ecma_5\extensions\misplaced-inconsistent-directive.js | (args: "--baseline-eager --no-fpu")
(Assignee)

Updated

4 years ago
Blocks: 1135394
(Assignee)

Comment 1

4 years ago
asm.js is not available on windows spidermonkey build with --no-fpu option, since cx->jitSupportsFloatingPoint() returns false.
So those parts in the test should be disabled on `!isAsmJSCompilationAvailable()`.
(Assignee)

Comment 2

4 years ago
Created attachment 8567572 [details] [diff] [review]
Do not test 'use asm' in ecma_5/extensions/misplaced-inconsistent-directive.js if asm.js is not available.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=42da6e931c3b&exclusion_state=all
Attachment #8567572 - Flags: review?(n.nethercote)
Comment on attachment 8567572 [details] [diff] [review]
Do not test 'use asm' in ecma_5/extensions/misplaced-inconsistent-directive.js if asm.js is not available.

Review of attachment 8567572 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok, but I'll ask an asm.js expert to review, just in case.
Attachment #8567572 - Flags: review?(n.nethercote) → review?(luke)

Updated

4 years ago
Attachment #8567572 - Flags: review?(luke) → review+
Blocks: 1126520
No longer blocks: 1135394
https://hg.mozilla.org/mozilla-central/rev/1c0f3c917ea5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Assignee: nobody → arai.unmht
https://hg.mozilla.org/releases/mozilla-esr38/rev/8d152e8ab1a8
status-firefox-esr38: --- → fixed
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.