Closed Bug 1135403 Opened 7 years ago Closed 7 years ago

Ensure canvas debugger works when rAF/setTimeout exist, but no canvas or canvas animation

Categories

(DevTools Graveyard :: Canvas Debugger, defect)

37 Branch
x86
macOS
defect
Not set
normal

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch 1135403-rafnocanvas.patch (obsolete) — Splinter Review
Works fine (times out), but here's a test to ensure that.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8568621 - Flags: review?(vporof)
Attachment #8568621 - Flags: review?(vporof) → review+
rebased
Attachment #8568621 - Attachment is obsolete: true
Attachment #8569272 - Flags: review+
The tests themselves somehow didn't get included when I imported the patch. :\
Hopefully this fixes things: 
https://hg.mozilla.org/integration/fx-team/rev/a606a0c2c2bc
Great, looks like it's good; I'll keep an eye on it. Thanks!
https://hg.mozilla.org/mozilla-central/rev/35a84923b632
https://hg.mozilla.org/mozilla-central/rev/a606a0c2c2bc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.