Remove unused browser.history preferences

RESOLVED FIXED in Firefox 38

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mfinkle, Unassigned)

Tracking

unspecified
Firefox 38
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

Created attachment 8567548 [details] [diff] [review]
prefs-cleanup v0.1

We used these prefs back in XUL Fennec days. And the "browser.sessionhistory.max_entries" preference is actually a dupe from a different location in mobile.js
Attachment #8567548 - Flags: review?(michael.l.comella)
Comment on attachment 8567548 [details] [diff] [review]
prefs-cleanup v0.1

Review of attachment 8567548 [details] [diff] [review]:
-----------------------------------------------------------------

r+ w/ nit. Don't forgot to add a commit description.

Are you sure you don't want to remove this from Metro too? [1] :P

[1]: https://mxr.mozilla.org/mozilla-central/search?string=browser.history.grouping&find=&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=mozilla-central

::: mobile/android/app/mobile.js
@@ -299,5 @@
>  pref("browser.xul.error_pages.enabled", true);
>  
> -pref("browser.history.grouping", "day");
> -pref("browser.history.showSessions", false);
> -pref("browser.sessionhistory.max_entries", 50);

This looks like it is still used:

https://mxr.mozilla.org/mozilla-central/source/docshell/shistory/src/nsSHistory.cpp?rev=cfa520bee5fc#40

Are you sure you want to remove it?
Attachment #8567548 - Flags: review?(michael.l.comella) → review+
(In reply to Michael Comella (:mcomella) from comment #1)

> Are you sure you don't want to remove this from Metro too? [1] :P

Metro stuff is being removed from the tree in a separate set of bugs.

> > -pref("browser.sessionhistory.max_entries", 50);
> 
> This looks like it is still used:
> 
> https://mxr.mozilla.org/mozilla-central/source/docshell/shistory/src/
> nsSHistory.cpp?rev=cfa520bee5fc#40
> 
> Are you sure you want to remove it?

This line was a dupe. We already have another "browser.sessionhistory.max_entries" line in mobile.js so we don't need two.
https://hg.mozilla.org/integration/fx-team/rev/18d513da3ce1
https://hg.mozilla.org/mozilla-central/rev/18d513da3ce1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.