1135506 - Attendee dialog: FreeBusy grid is blank if no organizer is associated to the calendar [Error: TypeError: this.getFreeBusyElement(...) is null]

Status: NEW

(Calendar :: Dialogs, defect)

Description

[[:MakeMyDay]]

STR:
1. create a calendar of any type without associating it to an email identity
2. create a new event for this calendar
3. press add attendee button

Result:
a blank FB grid and several error messages for this.getFreeBusyElement(...) in chrome://calendar/content/calendar-event-dialog-freebusy.xml:1127

Expected:
Either prohibit opening the attendee dialog if no organizer id is set for the respective calendar (disabling the button command in event dialog and eventually show a notification bar to explain this) or show the grid as usual (although inviting will not work without organizer, so at least a notification would be required, too).

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Came acrsoss this one too. Maybe we should fix it for Lightning 4.0. Seems pretty easy to encounter.

Comment 2

[[:MakeMyDay]]

I would suggest to disable the button if no organizer is configured to prevent opening the FB dialog in that case. Anything else would either require new strings or would end up in pretending a working invitation until the user completed preparing the invitation.

Philipp, what do you think?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Just disabling the button won't really help the user understand why, but I agree we can't change strings. This must have regressed from some time, I wonder what we did before. I think we just filled out the attendees and didn't send any invitations.

Both options are not ideal, so in the end I really don't mind which solution we take for 4.0.

Comment 4

[[:MakeMyDay]]

Not setting a proper organizer would be a not a good idea esp. for network calendars, even if we don't send an invitation. Storing an event with attendees but without an organizer is an RfC violation. Also, the user might try to do some scheduling operations from another client.

I've had a first look at this, but not yet a patch. Not sure whether I can prepare one for b3.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

MakeMyDay, any updates on this one?

Comment 6

[[:MakeMyDay]]

I'm still working on this. There's some edge cases to consider (changing calendar or having already an event without organizer but with attendees from previous version). I hope to have something ready over the weekend.

Comment 7

[themarginwalker]

Apologies in advance if this is not the correct forum for this comment. This issue has been somewhat crippling and in my case, even when associating a calendar with an email address, the Attendee dialogue is blank and does not allow for any input. I'm using Provider for Google Calendar for most of my calendars. Unfortunately I can't code, but happy to help in any other way...Thanks for working on this bug.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Can you file a separate bug on this issue in the "Provider: GData" component? Please also include any error messages from the error console, and possibly debug messages using https://wiki.mozilla.org/Calendar:GDATA_Provider#Enabling_Debugging

Comment 9

[:aceman]

I also encountered this. You can mistakenly start creating an event in an unusable calendar (like one without identity), and then you can easily change to a proper one (inside the event dialog). But until then you get this error in the "Invite attendees" dialog. Also, the error appears periodically, e.g. once per second while the dialog is open.

This is in LT 4.7.1 so the target milestone field is already outdated.

Comment 10

[[:MakeMyDay]]

Yes, the target milestone is misleading. I cannot find the patch I mentioned in comment 6 directly, but may I still have it somewhere.

Comment 12

[Worcester12345]

Version needs to get changed, since "Lightning" no longer exists.
" Version: Lightning 4.0.0.1"