Closed Bug 1135508 Opened 10 years ago Closed 9 years ago

InContent Prefs - Don't allow text selection of categories

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 39
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: staneck, Assigned: gioyik, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=css][good first bug])

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2305.3 Safari/537.36

Steps to reproduce:

Can you make it so that selecting a menu item does not cause a typing indicator[1] to appear? I also think it would feeld more "native" if you cannot select the text of the menu item.[2]

[1]: http://i.imgur.com/J2SRH1p.png
[2]: http://i.imgur.com/pJYXEg1.png
Blocks: 1014208
Component: Untriaged → Preferences
OS: Windows 8.1 → All
Hardware: x86 → All
See Also: → 1014208
Version: Trunk → unspecified
I actually just noticed that it does the typing indicator for all button elements, too. See http://i.imgur.com/s0bRCv2.gif
(In reply to Stanzilla from comment #1)
> I actually just noticed that it does the typing indicator for all button
> elements, too. See http://i.imgur.com/s0bRCv2.gif

This focus ring only appears when you start using the keyboard to navigate the UI, once you've done so, the focus ring reappears when you click. You get the same behavior in some parts of Windows. That focus ring is for accessibility too, so I suspect we'll ever remove that. 

I agree we should remove text selection from the category labels though (it is also consistent with the add-on manager). Let's use this bug for that.
Mentor: ntim007
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [lang=css][good first bug]
Summary: [chameleon] alter menu items style → InContent Prefs - Don't allow text selection of categories
(In reply to Tim Nguyen [:ntim] from comment #2)
> (In reply to Stanzilla from comment #1)
> > I actually just noticed that it does the typing indicator for all button
> > elements, too. See http://i.imgur.com/s0bRCv2.gif
> 
> This focus ring only appears when you start using the keyboard to navigate
> the UI, once you've done so, the focus ring reappears when you click. You
> get the same behavior in some parts of Windows. That focus ring is for
> accessibility too, so I suspect we'll ever remove that. 
Oh wait, I see you meant the text typing indicator (the gif didn't run for me at first).
For some reason, I can't seem to reproduce this.
Attached patch 1135508.patch (obsolete) — Splinter Review
Attachment #8567718 - Flags: review?(ntim007)
Assignee: nobody → gioyik
Status: NEW → ASSIGNED
Comment on attachment 8567718 [details] [diff] [review]
1135508.patch

Thanks for the patch !

The patch looks good, but there seems to be some unrelated changes in it.
Btw, can you ask :jaws for the next review ? My review is worth nothing :)
Attachment #8567718 - Flags: review?(ntim007)
Hi Tim,

You are right the patches get mixed, sorry for that. I am going to attach a new one fixed.

Thank you
Attached patch 1135508.patch (obsolete) — Splinter Review
Patch fixed!
Attachment #8567718 - Attachment is obsolete: true
Attachment #8567722 - Flags: review?(jaws)
We should probably apply this to category headers too, but the rest of the UI (like the checkboxes, radio buttons, etc. should remain selectable).
Attachment #8567722 - Flags: review?(jaws) → feedback+
Attached patch 1135508.patchSplinter Review
Patch v2
Attachment #8567722 - Attachment is obsolete: true
Attachment #8568394 - Flags: review?(jaws)
Attachment #8568394 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/fx-team/rev/32c84f014b3b
Keywords: checkin-needed
Whiteboard: [lang=css][good first bug] → [lang=css][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/32c84f014b3b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [lang=css][good first bug][fixed-in-fx-team] → [lang=css][good first bug]
Target Milestone: --- → Firefox 39
(In reply to Tim Nguyen [:ntim] from comment #2)
> (In reply to Stanzilla from comment #1)
> > I actually just noticed that it does the typing indicator for all button
> > elements, too. See http://i.imgur.com/s0bRCv2.gif
> 
> This focus ring only appears when you start using the keyboard to navigate
> the UI, once you've done so, the focus ring reappears when you click. You
> get the same behavior in some parts of Windows. That focus ring is for
> accessibility too, so I suspect we'll ever remove that. 
> 
> I agree we should remove text selection from the category labels though (it
> is also consistent with the add-on manager). Let's use this bug for that.

I uploaded the gif in a better resolution: https://dl.dropboxusercontent.com/s/5xaudrhnbdutb6o/2015-02-22_17-20-03.mp4?dl=0

I didn't use the keyboard for anything, I just clicked the button and the typing indicator appeared and started blinking as if you could write something into the button. That is not accessability thing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Maybe you inadvertently turned on Caret browsing? Press F7 to disable it.
(In reply to henryfhchan from comment #16)
> Maybe you inadvertently turned on Caret browsing? Press F7 to disable it.

Stanzilla, I think that might be the issue on your side. I've been able to reproduce this only with Caret Browsing Enabled.
Flags: needinfo?(staneck)
(In reply to henryfhchan from comment #16)
> Maybe you inadvertently turned on Caret browsing? Press F7 to disable it.

Yes, and you may want to see bug 993361 which is about the Caret being placed in the wrong position on XUL documents (such as the one in your video).
Oh. Indeed. I never heard the term Caret browsing before and I probably toggled it by accident. There is no indicator in the UI if it is currently enabled, right? Anyway, this bug can be closed.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Flags: needinfo?(staneck)
Resolution: --- → WORKSFORME
Resolution: WORKSFORME → FIXED
Comment on attachment 8568394 [details] [diff] [review]
1135508.patch

Approval Request Comment
[Feature/regressing bug #]: new feature, in-content prefs (icp)
[User impact if declined]: users will be able to highlight category names in the prefs in 38 but not in 39. we want to uplift all icp patches to firefox 38 so that the first release of the feature is solid.
[Describe test coverage new/current, TreeHerder]: landed on mozilla-central for some time now.
[Risks and why]: none expected.
[String/UUID change made/needed]: none.
Attachment #8568394 - Flags: approval-mozilla-aurora?
Attachment #8568394 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
QA Contact: camelia.badau
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 38 Beta 6 (buildID: 20150420134330) and latest Aurora 39.0a2 (buildID: 20150424004008).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: