abspos-related printing reftests fail when downloadable font cache is disabled

NEW
Unassigned

Status

()

4 years ago
4 years ago

People

(Reporter: jtd, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

4 years ago
While working improving reflow performance for pages with downloadable fonts (bug 935862), I've discovered a number of reftests that are explicitly dependent on loading downloadable fonts from the downloadable font cache. Reftests should always work whether or not the fonts used are cached or not. The difference is that when a font is taken from the font cache there isn't an extra load-reflow cycle that occurs.

It may be that the problem here is in the way the 'reftest-print' environment works. For bug 1135308 I landed a pref to explicitly disable the downloadable font cache which allows one to run all test suites without font loading being dependent on reftest load order.
(Reporter)

Comment 1

4 years ago
Tryserver build run with downloadable font cache explicitly disabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e2bb674428e
(Reporter)

Comment 2

4 years ago
There's another abspos-related printing reftest that's failing when the downloadable font cache is disabled.

REFTEST TEST-UNEXPECTED-PASS | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/pagination/abspos-breaking-000.xhtml | assertion count 0 is less than expected 3 assertions
TEST-UNEXPECTED-FAIL | leakcheck | default process: 664211 bytes leaked (AsyncLatencyLogger, AtomImpl, CDATASection, CSSStyleSheet, CSSStyleSheetInner, ...)
Summary: printing reftest for bug 1108104 fails on all platforms when downloadable font cache is disabled → abspos-related printing reftests fail when downloadable font cache is disabled
(Reporter)

Comment 3

4 years ago
Created attachment 8567800 [details] [diff] [review]
patch, disable svg-glyph-mask.svg reftest

Due to crash/assertion in bug 1135329
Attachment #8567800 - Flags: review?(m_kato)
(Reporter)

Updated

4 years ago
Blocks: 1135329
(Reporter)

Comment 4

4 years ago
Comment on attachment 8567800 [details] [diff] [review]
patch, disable svg-glyph-mask.svg reftest

argh, patch uploaded to the wrong bug... sorry for the noise...
Attachment #8567800 - Attachment is obsolete: true
Attachment #8567800 - Flags: review?(m_kato)
You need to log in before you can comment on or make changes to this bug.