1135556 - abspos-related printing reftests fail when downloadable font cache is disabled

Status: NEW

(Core :: Layout: Text and Fonts, defect)

Description

[John Daggett (:jtd)]

While working improving reflow performance for pages with downloadable fonts (bug 935862), I've discovered a number of reftests that are explicitly dependent on loading downloadable fonts from the downloadable font cache. Reftests should always work whether or not the fonts used are cached or not. The difference is that when a font is taken from the font cache there isn't an extra load-reflow cycle that occurs.

It may be that the problem here is in the way the 'reftest-print' environment works. For bug 1135308 I landed a pref to explicitly disable the downloadable font cache which allows one to run all test suites without font loading being dependent on reftest load order.

Comment 1

[John Daggett (:jtd)]

Tryserver build run with downloadable font cache explicitly disabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e2bb674428e

Comment 2

[John Daggett (:jtd)]

There's another abspos-related printing reftest that's failing when the downloadable font cache is disabled.

REFTEST TEST-UNEXPECTED-PASS | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/pagination/abspos-breaking-000.xhtml | assertion count 0 is less than expected 3 assertions
TEST-UNEXPECTED-FAIL | leakcheck | default process: 664211 bytes leaked (AsyncLatencyLogger, AtomImpl, CDATASection, CSSStyleSheet, CSSStyleSheetInner, ...)

Comment 3

[John Daggett (:jtd)]

Attachment: patch, disable svg-glyph-mask.svg reftest

Due to crash/assertion in bug 1135329

Comment 4

[John Daggett (:jtd)]

Comment on attachment 8567800 [details] [diff] [review]
patch, disable svg-glyph-mask.svg reftest

argh, patch uploaded to the wrong bug... sorry for the noise...