1135582 - [js client] We should return 'undefined' when the content length is 0 or the content type is not json

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

When the server sends us an empty repsonse, we should be returning undefined.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-client

https://github.com/taskcluster/taskcluster-client/commit/e5a549bbedc769d305f55922ff881e7b071e32a6
Bug 1135582
Return undefined on empty response from server.
	modified:   lib/client.js

https://github.com/taskcluster/taskcluster-client/commit/1331e9fb12b6eca46c26dea8a5c9e7bd3173d031
Bug 1135582
Return undefined on empty response from server

Returns undefined if response is empty or content-type is not
application/json

	modified:   lib/client.js

https://github.com/taskcluster/taskcluster-client/commit/4ed666af1cc7df94ec77d4c020c3f19c15f1e3ab
Merge pull request #46 from ckousik/undef

Bug 1135582

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

This will be released with the next version... Thanks for the fix! :)

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

This doesn't return undefined -- it raises an exception.  Which is not what we want, as we have lots of API methods that don't return a body or res['content-type'].  With this change, we're getting `res.headers['content-type'] is null`.  This has left the tools UI pretty broken.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/300bb87ce7a005fd864c1237fcf363003d0214e7
Bug 1135582: pin taskcluster-client to a working version

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

I've pinned tools to use 2.23.13.

https://github.com/taskcluster/taskcluster-client/pull/48