Disable dormant decoder shutdown on 37

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

37 Branch
x86
Windows 8
Points:
---

Firefox Tracking Flags

(firefox37 fixed)

Details

Attachments

(1 attachment)

We're not confident with the current implementation. Better to disable this for the first beta.
(Assignee)

Comment 1

4 years ago
Created attachment 8567819 [details] [diff] [review]
Disable dormant shutdown patch for 37
Assignee: nobody → giles
Attachment #8567819 - Flags: review?(cpearce)
(Assignee)

Comment 2

4 years ago
Dormant code is windows only.
OS: Mac OS X → Windows 8
(Assignee)

Updated

4 years ago
status-firefox37: --- → affected
Attachment #8567819 - Flags: review?(cpearce) → review+
We should re-enbale in 37 once Sotaro lands his fixes.
(Assignee)

Comment 4

4 years ago
Landed on 37 aurora with pre-approval from lmandel.

https://hg.mozilla.org/releases/mozilla-aurora/rev/030fa1665346
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox37: affected → fixed
Resolution: --- → FIXED
(Assignee)

Comment 5

4 years ago
Comment on attachment 8567819 [details] [diff] [review]
Disable dormant shutdown patch for 37

Requesting retroactive 37 uplift approval for tracking. This is the dormant pref flip I mentioned needing on Friday.

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Possible issues with YouTube interaction.
[Describe test coverage new/current, TreeHerder]: This turns off new code, reverting to earlier behaviour.
[Risks and why]: This will make us use more resources on background MSE tabs, which may contribute to oom crashes or playback failure, but we feel this is a safer config for the first beta.
[String/UUID change made/needed]: None.
Attachment #8567819 - Flags: approval-mozilla-aurora?
Comment on attachment 8567819 [details] [diff] [review]
Disable dormant shutdown patch for 37

As noted, pre-approval was granted for a collection of MSE changes. Adding approval to the bug.
Attachment #8567819 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.