Closed Bug 1135616 Opened 9 years ago Closed 9 years ago

Test failure 'Entity - oldSecurityProtocol.title has been found - got 'null'' in testSSLDisabledErrorPage.js

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox37 unaffected, firefox38 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox37 --- unaffected
firefox38 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: regression, Whiteboard: [mozmill-test-failure])

Attachments

(2 files, 1 obsolete file)

skip patch
1.05 KB, patch
Details | Diff | Splinter Review
Fix v1
2.92 KB, patch
automatedtester
: review+
Details | Diff | Splinter Review 
This fails across platforms for Firefox Nightly since yesterday. So most likely an entity change on that branch.
Regressor here is bug 1127339 given the changelog and the lines as listed below:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5de3af90c494&tochange=0cefb584fd1a
https://hg.mozilla.org/mozilla-central/rev/01fb39cc4980#l2.68

Given that this is a remote security test I'm updating that failing test, so we can make sure that people do not run into trouble when converting the test to Marionette.
Blocks: 1127339
Keywords: regressionwindow-wanted
Attached patch skip patch (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        skip patch
        — 
          — Splinter Review
      

    


  
Missed to qref the changes.

        Attachment #8567877 -
        Attachment is obsolete: true

    
    

    
  
I have problems to find the right DTD entity to compare the error title with. So I landed the skip patch for now on the default branch to prevent test failures today.

https://hg.mozilla.org/qa/mozmill-tests/rev/5265e172e153

          status-firefox37:
          --- → unaffected

          status-firefox38:
          --- → disabled
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]

    
    

    
  
A part of the test still fails which checks the errorcode element for its value. With the patch on bug 1127339 it has been removed. I asked over there if it was on purpose or by accident. I will wait with a fix here, until that has been clarified.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix v1
        — 
          — Splinter Review
      

    


  
This fixes the regression in our P1 security tests by:

* Checking for the correct DTD entity for the failure title
* Removing the dependency of the non-existent DOM node ("errorcode") by checking if the expected test is part of the short description
* drive-by change from assert->expect to not stop the test when the try again button is not available

        Attachment #8567896 -
        Flags: review?(dburns)

        Attachment #8567896 -
        Flags: review?(dburns) → review+

    
    

    
  
https://hg.mozilla.org/qa/mozmill-tests/rev/cb2ed4f8c2fa (default)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox38:
          disabled → fixed
Resolution: --- → FIXED
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]
Target Milestone: --- → Firefox 38

    
  
Product: Mozilla QA → Mozilla QA Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: