1135622 - unexpected variations in width of <input type=number> when running reftests

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jonathan Kew [:jfkthame]]

The horizontal writing-mode examples of number controls in reftests/writing-mode/ua-style-sheet-input-number-1.html display as expected when the testcase and reference are loaded locally. However, when they're run by the reftest framework, the number fields in the testcase vary significantly in width (in varying ways across different platforms). See the test failures in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e37d57033b13.

I'm proposing to mark this test as failing for now (note that its vertical writing-mode portion is commented out anyway, due to bug 1123299), so that we can proceed to enable the rest of the writing-mode test directory. Offhand, I don't see an obvious reason why this test is misbehaving, but we should investigate and resolve this, perhaps along with 1123299.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: The number-control.css stylesheet should be treated as a UA sheet when loaded, so that the inline-size property is recognized

The number-control.css file belongs logically as a part of forms.css, and should also be loaded as a UA sheet with the same access to properties. Without this, we get an unexpected difference in behavior (in horizontal writing mode) depending whether the vertical-text pref is enabled, as that determines whether the inline-size property is recognized or not.

Comment 2

[Jonathan Kew [:jfkthame]]

And this should allow us to remove the "fails" annotation from reftests/writing-mode/ua-style-sheet-input-number-1.html, which is failing because the inline-size property is discarded. I've pushed a try job to check; this should report "unexpected passes" on that test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9aced5cf3e6b.

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf3beee5149

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2cf3beee5149

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8568004 [details] [diff] [review]
The number-control.css stylesheet should be treated as a UA sheet when loaded, so that the inline-size property is recognized

Approval Request Comment
[Feature/regressing bug #]: bug 1119475
[User impact if declined]: UA stylesheet fails to set the intended default width for <input type="number"> elements.
[Describe test coverage new/current, TreeHerder]: Reftest is in the tree, though currently disabled; will be enabled in bug 1134598 once the leak that forced a backout there is resolved. (Local testing and tryserver runs confirm the reftest will pass when it gets enabled.)
[Risks and why]: minimal
[String/UUID change made/needed]: n/a

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8568004 [details] [diff] [review]
The number-control.css stylesheet should be treated as a UA sheet when loaded, so that the inline-size property is recognized

Approving for uplift to aurora since it sounds low risk. It would be good to get the test coverage uplifted as well before this goes to beta.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e76ef30e2931