1135629 - Clean-up: Rename some Register::code() to Register::encoding().

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

Bug 1112164 add aliases to x86/x64 FloatRegisters, which implies to separate the function which are providing the encoding of the register from the function in charge of providing the index of the typed-register in the SetType.

At the same time, or as a follow-up, we should rename the remaining uses of code() to be something such as setIndex().

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: bug1135629.patch

This follow the modification previously made for SIMD registers, which is to disintguish between the register index in the Set mask, and the register encoding in the generated assembly code.

Unfortunately, by using an integral type for Code does not target wrong uses on the ARM backend, as the Register abstraction are used quite deep in the ARM Assembler, while one might expect to see the enumerated value only as on x86&x64.

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8586154 [details] [diff] [review]
bug1135629.patch

Review of attachment 8586154 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Disassembler.h
@@ +17,5 @@
>  
>  class ComplexAddress {
>      int32_t disp_;
> +    uint32_t base_ : 8;
> +    uint32_t index_ : 8;

I reverted this changes, and changed the Architecture-arm.h file to use Encoding instead of Code for the Invalid register.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8586154 [details] [diff] [review]
bug1135629.patch

Review of attachment 8586154 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=me with the disassembler change reverted.

::: js/src/jit/shared/Assembler-x86-shared.h
@@ +27,5 @@
>      };
>  
>    private:
>      Kind kind_ : 4;
> +    // Used as a Register::Encoding and a FloatRegisterEncoding.

FloatRegister::Encoding?

Comment 4

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a4650f2e28a2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4650f2e28a2