1135649 - [Messages] Can't autocomplete email recipients

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. have 1 contact with only an email, no phone number
2. in the Messages app, tap "new message" button
3. write letters until the aforementioned contact is the first one in the suggestions list.
4. press "enter"

Expected:
=> the aforementioned contact should be added to the recipients list.

Actual:
=> it's not added. Instead, either the next contact that has a phone number is added, or no contact is added if there is none, leaving an invalid recipient.

Comment 1

[Maria Angeles Oteo (:oteo)]

This issue only reproduces in 2.2 and master branches as the "Send MMS to e-mail addresses" feature was landed in 2.2.

Just adding that the recipient (contact with only e-mail addres) is added correctly if user presses on it in the suggested listed but not if the contact is the first one in the suggested list and user presses "enter" key. 
As Julien explains, we should be coherent and offer the same functionality than when a contact has a phone number.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Triage: Missing use case of a new functionality.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] julienw:1135649-autocomplete-email-recipients > mozilla-b2g:master

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8569856 [details] [review]
[gaia] julienw:1135649-autocomplete-email-recipients > mozilla-b2g:master

Hey Oleg, what do you think of this?

The issue is that "Utils.isEmailAddress" is not the correct thing to use here, because fValue can be a name, or even the start of an email address. Instead I iterate all values (tels + emails).

There is remaining issue that we'll handle in bug 1084184: if we enter an email that matches a contact that also has phone numbers, and we press enter, the first displayed entry is taken.

I think this is still understandable because it's the first displayed entry, but this is misleading. Note that the same happens when a contact has 2 phone numbers, which is bug 1084184, that's why I suggest that we handle both cases in that bug.

Tell me what you think !

Comment 5

[Julien Wajsberg [:julienw]]

Mmm I think I miss a unit test, I'll add one tomorrow, but you can still give me a first feedback if you want.

Comment 6

[Julien Wajsberg [:julienw]]

New test added, you can review :)

Comment 7

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8569856 [details] [review]
[gaia] julienw:1135649-autocomplete-email-recipients > mozilla-b2g:master

Looks good, thanks!

Comment 8

[Julien Wajsberg [:julienw]]

Fixed nits and landed:

master: 6f6c7645e3b63368e0c5f0c832cc72fb7df71342

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8569856 [details] [review]
[gaia] julienw:1135649-autocomplete-email-recipients > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): new feature introduced in bug 974867
[User impact] if declined: incorrect behavior when looking for an email and pressing enter
[Testing completed]: yes, manually and unit tests
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/90dd2398e08793d8f24a3173be8bc24feabec192

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed for the latest Nightly 3.0 and 2.2 builds.

Actual Results:  Adding a contact with only an email address by name works as expected in the mms app.
	
Environmental Variables:
Device: Flame 3.0 KK (319 MB) (Full Flash)
BuildID: 20150304010324
Gaia: 3fc0ac309f5fb0c1fe82c12223b955a4efce27e6
Gecko: c5b90c003be8
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (319 MB) (Full Flash)
BuildID: 20150304002529
Gaia: 8b4b3e4b7e7c308764f71542437fd60625ac6b75
Gecko: 2cb52b7cda5a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0