1135651 - Sanitise e-mail test variables

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

A failure running our e-mail tests via the remote device lab (see bug 1135638) brought my attention to some issues with our e-mail test variables. At the moment we have SMTP account details within the IMAP dictionary, and several keys have a superfluous prefix. Let's clean this up.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Link to Github pull-request: https://github.com/mozilla/webqa-credentials/pull/192

This patch adds the new keys to the test variable files. The next patch will make use of these keys, and once it's landed we can remove the obsolete keys.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] davehunt:bug1135651 > mozilla-b2g:master

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8567909 [details] [review]
Link to Github pull-request: https://github.com/mozilla/webqa-credentials/pull/192

I don't see any change which should be here. r+!

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Link to Github pull-request: https://github.com/mozilla/webqa-credentials/pull/193

Note that this needs to land after the gaiatest patch lands.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8567952 [details] [review]
Link to Github pull-request: https://github.com/mozilla/webqa-credentials/pull/193

Like you told me on IRC, we can get rid of the "name"s variables. Looks good to me!

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8567914 [details] [review]
[gaia] davehunt:bug1135651 > mozilla-b2g:master

Forgot to request review on this one - it needs to land before the final webqa-credentials one.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8567914 [details] [review]
[gaia] davehunt:bug1135651 > mozilla-b2g:master

I don't see any issue in this refactor. I applied the changes to my testvars.json file and run the tests under functional/email, everything passed except:
* test_setup_and_send_active_sync_email.py
* test_receive_active_sync_email.py
* test_IMAP_email_notification.py (due to bug 1132479)

I copied the credentials from the webqa-credentials repo but the Email app says they are not correct.

Asking John for a second review to be safe.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

As I understand it the ActiveSync accounts are dedicated to specific devices. I've therefore triggered an adhoc build in Jenkins: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/707/

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The last adhoc ran on a device without ActiveSync account details in the testvars. I've triggered another on a specific device: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/708/

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Hmm.. it seems the ActiveSync tests are actually disabled due to bug 1028192. If that's the case, can we go ahead and land this?

Comment 11

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8567914 [details] [review]
[gaia] davehunt:bug1135651 > mozilla-b2g:master

My bad, I know why they got run on my device: I asked to run gaiatest/tests/functional/email instead of the manifest in it.

I'm okay with landing these patches.

Comment 12

[Johan Lorenzo [:jlorenzo]]

Gaia PR merged in master at: https://github.com/mozilla-b2g/gaia/commit/e6e065165145aa0e862cb69e85f23e08ddcc2804

Comment 13

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I had to push a followup fix here: https://github.com/mozilla-b2g/gaia/commit/0f9390344d28e94edcf782cf6722284d7ae6a3ae

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Final patch landed in:
https://github.com/mozilla/webqa-credentials/commit/6351eb9eb47294daf73f93060bd4f5f6d43892e2