Closed
Bug 1135671
Opened 9 years ago
Closed 9 years ago
'resources' is defined twice in mozreview/extension.py
Categories
(MozReview Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
This commit redefined 'resources' instead of adding to it: http://hg.mozilla.org/hgcustom/version-control-tools/rev/0521758ed49b This in turn caused me much confusion when rebasing my review request in https://reviewboard.mozilla.org/r/2837/ It also indicates that we have no tests for batch_review_resource, since overwriting 'resources' means it won't be available via the extension.
|
Assignee | |
Comment 1•9 years ago
|
||
/r/4165 - Bug 1135671 - Fix redefined of WebAPI resources in mozreview extension. Pull down this commit: hg pull review -r 46ca138e2012cf38a4255210eb6ceeb92744a5dc
Attachment #8567929 -
Flags: review?(mconley)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8567929 [details] MozReview Request: bz://1135671/mcote https://reviewboard.mozilla.org/r/4163/#review3319 Guh
Attachment #8567929 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
http://hg.mozilla.org/hgcustom/version-control-tools/rev/6d2637486d85
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8567929 -
Attachment is obsolete: true
Attachment #8619560 -
Flags: review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
||
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•