1135684 - move build/unix/Makefile.in to moz.build

Status: NEW

(Firefox Build System :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move build/unix/Makefile.in to moz.build

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8567948 [details] [diff] [review]
move build/unix/Makefile.in to moz.build

>-SDK_BINARY = run-mozilla.sh

>+FINAL_TARGET_FILES += ['run-mozilla.sh']

From config/rules.mk, it looks like SDK_BINARY would only install run-mozilla.sh if COMPILE_ENVIRONMENT if set. If unset, SDK_BINARY only installs python files. Does that seem right? If so, we might need to wrap this in an if CONFIG['COMPILE_ENVIRONMENT'], or make a separate SDK_BINARY moz.build variable that does this automatically.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8567948 [details] [diff] [review]
move build/unix/Makefile.in to moz.build

Review of attachment 8567948 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by comment: it's nice to see patches like that that convert 9 lines of sigil-heavy makefile code to 3 lines of vanilla-looking Python code.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.