If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Test Case - Add wallpaper change test in imagecompare suite

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njpark, Assigned: njpark)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
davehunt
: review+
Martijn Wargers (dead)
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Reuse test_homescreen_change_wallpaper.py to verify the wallpaper change
(Assignee)

Updated

3 years ago
Assignee: nobody → npark
(Assignee)

Comment 1

3 years ago
Takes screenshots of each steps in changing wallpaper to a gallery photo.

Comment 2

3 years ago
Created attachment 8567972 [details] [review]
[gaia] npark-mozilla:1135692 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Component: Marionette → Gaia::UI Tests
Product: Testing → Firefox OS
(Assignee)

Comment 3

3 years ago
Comment on attachment 8567972 [details] [review]
[gaia] npark-mozilla:1135692 > mozilla-b2g:master

Basically this reuses test_homescreen_change_wallpaper.py in functional/homescreen folder, adding screenshot methods
Attachment #8567972 - Flags: review?(martijn.martijn)
Attachment #8567972 - Flags: review?(dave.hunt)

Updated

3 years ago
Attachment #8567972 - Flags: review?(dave.hunt) → review+
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
Comment on attachment 8567972 [details] [review]
[gaia] npark-mozilla:1135692 > mozilla-b2g:master

The test looks fine to me on itself.
I tried to run this test, but I get all kinds of error messages, like:
Ref file not found for: screenshots/test_homescreen_change_wallpaper_from_gallery_desktop_5+2015-02-24-15-40-27.png

I then tried to follow the instructions at:
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Marionette/Run_ImageMagick_Tool_with_Python_Marionette
But then I get this error:
gaiatest: error: no such option: --get-reference-image
Attachment #8567972 - Flags: review?(martijn.martijn) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

3 years ago
(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> Comment on attachment 8567972 [details] [review]
> [gaia] npark-mozilla:1135692 > mozilla-b2g:master
> 
> The test looks fine to me on itself.
> I tried to run this test, but I get all kinds of error messages, like:
> Ref file not found for:
> screenshots/test_homescreen_change_wallpaper_from_gallery_desktop_5+2015-02-
> 24-15-40-27.png
> 
> I then tried to follow the instructions at:
> https://developer.mozilla.org/en-US/docs/Mozilla/QA/Marionette/
> Run_ImageMagick_Tool_with_Python_Marionette
> But then I get this error:
> gaiatest: error: no such option: --get-reference-image

Ahh, the doc may be out of date. it should be --store-reference-image.  It was changed per davehunt's suggestion

Comment 6

3 years ago
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c969ba09b4ce1dc8e424889205720d7df0cc1012

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.