44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
We'll start with the ones for dev. These are the ones called from the cron that is already in bedrock.
This should also fix dev auto deploy.
Created attachment 8569143 [details] [review] Link to Github pull-request: https://github.com/mozilla/bedrock/pull/2767
:jakem as I commented in https://github.com/mozilla/bedrock/pull/2767#issuecomment-77109507 I think that should be safe to merge as-is, but I'd appreciate another pair of eyes on it just to be sure. After we merge that, I think we should also consider moving the following scripts into the bedrock repo: /data/bedrock/deploy /data/bedrock-dev/deploy /data/bedrock-stage/deploy Unlike the files in PR 2767, I believe those will require some minor changes in puppet. Following the same pattern as we have for other files, we would copy the existing files into the bedrock repo, and then change the puppet scripts to turn the existing files into symlinks in the appropriate directories for dev, stage, and prod. Does this sound good to you, :jakem?
Jake gave this a once over and I took a peek too, seems alright. As long as we do dev/stage first we should catch any potential issues before switching stuff in production. Thanks!
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/76260016dfe41562ef9931e28f97d8206836b337 Fix bug 1135693: Add update scripts to repo. https://github.com/mozilla/bedrock/commit/0bd2c30104e7631f05439b025930a73379184229 Merge pull request #2767 from pmclanahan/move-update-scripts-to-repo-1135693 Fix bug 1135693: Add update scripts to repo.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(In reply to Shyam Mani [:fox2mike] from comment #4) > Jake gave this a once over and I took a peek too, seems alright. > > As long as we do dev/stage first we should catch any potential issues before > switching stuff in production. > > Thanks! Thanks :fox2mike and :jakem! As you can see from comment #5 I just merged these in master, and I'll push to stage on Monday for testing.
You need to log in before you can comment on or make changes to this bug.