Closed
Bug 1135712
Opened 9 years ago
Closed 9 years ago
Typo in activesync-lib/protocol.js
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: max, Unassigned)
Details
Attachments
(2 files)
On line 632 of activesync-lib/protocol.js (https://github.com/mozilla-b2g/gaia/blob/master/apps/email/js/ext/ext/activesync-lib/protocol.js#L632) var key = iter[0], key = iter[1]; xhr.setRequestHeader(key, value); should presumably be var key = iter[0], value = iter[1]; xhr.setRequestHeader(key, value);
Comment 1•9 years ago
|
||
Good eye! Thank you! Unfortunately, we fixed https://github.com/mozilla-b2g/jsas/issues/21 but never actually took the fixed commit (https://github.com/mozilla-b2g/jsas/commit/0fd20952f23112976b3642c71a5f062341e677a2) in GELAM. We're still on its parent.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•9 years ago
|
||
Oh, hah! That was you who reported it before too!
Comment 3•9 years ago
|
||
Comment 4•9 years ago
|
||
Updated•9 years ago
|
Attachment #8568729 -
Flags: review+
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/27b7ed1c32511f805fb7220884416674b3d07f6e
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•